Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add HC detector request/failure stats #307

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

ylwu-amzn
Copy link
Contributor

Issue #, if available:

Description of changes:
Add high cardinality detector request/failure stats

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #307 (9076421) into master (f0105cc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #307      +/-   ##
============================================
+ Coverage     72.20%   72.25%   +0.05%     
- Complexity     1989     1991       +2     
============================================
  Files           201      201              
  Lines          9547     9561      +14     
  Branches        847      849       +2     
============================================
+ Hits           6893     6908      +15     
+ Misses         2243     2241       -2     
- Partials        411      412       +1     
Flag Coverage Δ Complexity Δ
cli 79.27% <ø> (ø) 0.00 <ø> (ø)
plugin 71.68% <100.00%> (+0.05%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java 94.82% <100.00%> (+0.09%) 11.00 <0.00> (ø)
...opendistroforelasticsearch/ad/stats/StatNames.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...rch/ad/transport/AnomalyResultTransportAction.java 80.80% <100.00%> (+0.46%) 71.00 <1.00> (+3.00)
...asticsearch/ad/cluster/ADClusterEventListener.java 92.00% <0.00%> (-2.00%) 14.00% <0.00%> (-1.00%)
...port/SearchAnomalyDetectorInfoTransportAction.java 63.63% <0.00%> (+4.54%) 4.00% <0.00%> (ø%)

@@ -258,6 +269,10 @@ protected void doExecute(Task task, ActionRequest actionRequest, ActionListener<
}

AnomalyDetector anomalyDetector = detectorOptional.get();
if (anomalyDetector.getCategoryField() != null && anomalyDetector.getCategoryField().size() > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use this instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks, will change

@ylwu-amzn ylwu-amzn merged commit 10dff2a into opendistro-for-elasticsearch:master Nov 10, 2020
@weicongs-amazon weicongs-amazon added the enhancement New feature or request label Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants