remove spotless header file; remove copyright year in new files for h… #372
Conversation
…istorical detector
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
============================================
- Coverage 79.00% 78.93% -0.08%
+ Complexity 2657 2653 -4
============================================
Files 247 247
Lines 11719 11719
Branches 1009 1009
============================================
- Hits 9259 9250 -9
- Misses 1986 1992 +6
- Partials 474 477 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -451,7 +451,6 @@ spotless { | |||
| java { | |||
| removeUnusedImports() | |||
| importOrder 'java', 'javax', 'org', 'com' | |||
| licenseHeaderFile 'spotless.license.java' | |||
There was a problem hiding this comment.
Would this mean we would not mandate the license header for new files?
Can't we just remove the year?
There was a problem hiding this comment.
The license header is still mandatory. If license header is missing, can't pass gradle build.
From Aloitta, we can remove copyright header for new files and keep old files as is. So I just removed copyright year in new files for AD historical detector in this PR. We can't specify a license header file without copyright year, otherwise the old files which has copyright year will fail gradle build.
There was a problem hiding this comment.
Got it. Thanks. I guess AD Kibana should follow the same standard.
There was a problem hiding this comment.
Created AD Kibana issue here. @ylwu-amzn is confirming on whether or not to change all older files to the new non-year format as well.
There was a problem hiding this comment.
Makes sense, thanks @ylwu-amzn !
There was a problem hiding this comment.
It is confirmed to leave the older files as they exist. Changes should only be made based on recently-created files (like historical-detector related code).
There was a problem hiding this comment.
From Alolita, “the open source community is used to having older formats in older code” we should not remove copyright year from old files. So we will just remove copyright year in new files from 2021
| @@ -451,7 +451,6 @@ spotless { | |||
| java { | |||
| removeUnusedImports() | |||
| importOrder 'java', 'javax', 'org', 'com' | |||
| licenseHeaderFile 'spotless.license.java' | |||
There was a problem hiding this comment.
Got it. Thanks. I guess AD Kibana should follow the same standard.
…istorical detector
Description of changes:
1.Remove copyright year in new files for historical detector
2.Remove hard code spotless header file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.