From 2083a2b12c0edda00eda5edd8732f2f4315d42aa Mon Sep 17 00:00:00 2001 From: Nikolaos Passalis Date: Thu, 21 Apr 2022 10:42:38 +0300 Subject: [PATCH 1/5] clang fixes --- src/opendr/control/mobile_manipulation/src/utils.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/opendr/control/mobile_manipulation/src/utils.cpp b/src/opendr/control/mobile_manipulation/src/utils.cpp index e418d49b51..de6048ba1e 100644 --- a/src/opendr/control/mobile_manipulation/src/utils.cpp +++ b/src/opendr/control/mobile_manipulation/src/utils.cpp @@ -194,7 +194,9 @@ namespace utils { return diff; } - bool startsWith(const std::string &str, const std::string &substr) { return (str.find(substr) == 0); } + bool startsWith(const std::string &str, const std::string &substr) { + return (str.find(substr) == 0); + } bool endsWith(const std::string &str, const std::string &substr) { size_t pos = str.rfind(substr); From 975047c4874d60ba190590f6e0982ccd2dbaa312 Mon Sep 17 00:00:00 2001 From: Nikolaos Passalis Date: Thu, 21 Apr 2022 11:08:34 +0300 Subject: [PATCH 2/5] Changed version of clang in MacOS --- .github/workflows/tests_suite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_suite.yml b/.github/workflows/tests_suite.yml index a2e65af3c5..ae677c9077 100644 --- a/.github/workflows/tests_suite.yml +++ b/.github/workflows/tests_suite.yml @@ -30,7 +30,7 @@ jobs: - os: ubuntu-20.04 DEPENDENCIES_INSTALLATION: "sudo apt -y install clang-format-10 cppcheck" - os: macos-10.15 - DEPENDENCIES_INSTALLATION: "brew install clang-format cppcheck" + DEPENDENCIES_INSTALLATION: "brew install clang-format@11 cppcheck" runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 From a87dd948c80f7dec96e9b5d3cbfb397cf5353ce8 Mon Sep 17 00:00:00 2001 From: Nikolaos Passalis Date: Thu, 21 Apr 2022 11:09:20 +0300 Subject: [PATCH 3/5] Revert change --- src/opendr/control/mobile_manipulation/src/utils.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/opendr/control/mobile_manipulation/src/utils.cpp b/src/opendr/control/mobile_manipulation/src/utils.cpp index de6048ba1e..e418d49b51 100644 --- a/src/opendr/control/mobile_manipulation/src/utils.cpp +++ b/src/opendr/control/mobile_manipulation/src/utils.cpp @@ -194,9 +194,7 @@ namespace utils { return diff; } - bool startsWith(const std::string &str, const std::string &substr) { - return (str.find(substr) == 0); - } + bool startsWith(const std::string &str, const std::string &substr) { return (str.find(substr) == 0); } bool endsWith(const std::string &str, const std::string &substr) { size_t pos = str.rfind(substr); From 5c6b98245aa7e3005eecd1e177cff8e1686a5a3c Mon Sep 17 00:00:00 2001 From: Nikolaos Passalis Date: Thu, 21 Apr 2022 11:24:29 +0300 Subject: [PATCH 4/5] Update tests_suite.yml --- .github/workflows/tests_suite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_suite.yml b/.github/workflows/tests_suite.yml index ae677c9077..4e60663d89 100644 --- a/.github/workflows/tests_suite.yml +++ b/.github/workflows/tests_suite.yml @@ -30,7 +30,7 @@ jobs: - os: ubuntu-20.04 DEPENDENCIES_INSTALLATION: "sudo apt -y install clang-format-10 cppcheck" - os: macos-10.15 - DEPENDENCIES_INSTALLATION: "brew install clang-format@11 cppcheck" + DEPENDENCIES_INSTALLATION: "brew install clang-format@14 cppcheck" runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 From ca3a716b4fd1e8859ebda34bbe7d44ebfd4fd368 Mon Sep 17 00:00:00 2001 From: Nikolaos Passalis Date: Thu, 21 Apr 2022 12:18:51 +0300 Subject: [PATCH 5/5] Switched to clang 11 --- .github/workflows/tests_suite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_suite.yml b/.github/workflows/tests_suite.yml index 4e60663d89..81a846d0f0 100644 --- a/.github/workflows/tests_suite.yml +++ b/.github/workflows/tests_suite.yml @@ -30,7 +30,7 @@ jobs: - os: ubuntu-20.04 DEPENDENCIES_INSTALLATION: "sudo apt -y install clang-format-10 cppcheck" - os: macos-10.15 - DEPENDENCIES_INSTALLATION: "brew install clang-format@14 cppcheck" + DEPENDENCIES_INSTALLATION: "brew install clang-format@11 cppcheck; ln /usr/local/bin/clang-format-11 /usr/local/bin/clang-format" runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2