fix(pstor): increase persistence timeouts #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishnu
approved these changes
Dec 15, 2023
hrudaya21
approved these changes
Dec 15, 2023
Done. |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
1564: fix(pstor): increase persistence timeouts r=tiagolobocastro a=tiagolobocastro The pstor might might unavailable for some time, for example during upgrade. We should have sufficient timeouts to cope with this. Also pstor can get slow at times as it's writing to disk, so we also should have a larger timeout on store. todo: should we still carry on trying to persist on separate task after we fail the nexus? todo: what happens when we try to shutdown nexus first and pstor fails? We'll revisit this post-release. Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
The pstor might might unavailable for some time, for example during upgrade. We should have sufficient timeouts to cope with this. Also pstor can get slow at times as it's writing to disk, so we also should have a larger timeout on store. todo: should we still carry on trying to persist on separate task after we fail the nexus? todo: what happens when we try to shutdown nexus first and pstor fails? Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
pstor-timeout
branch
from
cfb9e62
to
ac4a5f3
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pstor might might unavailable for some time, for example during upgrade. We should have sufficient timeouts to cope with this. Also pstor can get slow at times as it's writing to disk, so we also should have a larger timeout on store.
todo: should we still carry on trying to persist on separate task after we fail the nexus?
todo: what happens when we try to shutdown nexus first and pstor fails?
We'll revisit this post-release.