Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing to see what happens when I change a source string #31276

Closed

Conversation

pomegranited
Copy link
Contributor

without re-extracting the source messages.

Description

Draft OSPR to test whether/how our CI quality checks detect an altered source string that hasn't been pulled into the compiled messages.

Supporting information

cf openedx/open-edx-proposals#367 (comment)

Testing instructions

CI should be enough

Deadline

None -- do not merge :)

without re-extracting the source messages.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 10, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks
Copy link

@pomegranited Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@jansenk
Copy link
Contributor

jansenk commented Nov 10, 2022

What were you expecting to see in this PR? Did it happen or not?

@pomegranited
Copy link
Contributor Author

Hi @jansenk -- I was hoping the CI build would fail, because I'd changed a source string without also submitting an update to the compiled strings.

But it didn't fail, all checks were green. So that means we don't have any CI checks for this, and so keeping source strings extracted, compiled, and synced to Transifex must be handled by the transifex bot?

@pomegranited pomegranited deleted the jill/test-compilemessages branch November 1, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants