-
Notifications
You must be signed in to change notification settings - Fork 169
feat: add design tokens support #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add design tokens support #1758
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4f1d6cb to
8554eb9
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
c840172 to
d924a8b
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
9bc8e3f to
fe31d59
Compare
|
Sandbox deployment failed 💥 |
7e0fe48 to
d8def1c
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
d8def1c to
a3556d1
Compare
|
Sandbox deployment successful 🚀 |
9b37787 to
e4e0125
Compare
|
Sandbox deployment successful 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #1758 +/- ##
=======================================================
Coverage ? 93.82%
=======================================================
Files ? 1150
Lines ? 24056
Branches ? 5194
=======================================================
Hits ? 22570
Misses ? 1409
Partials ? 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment successful 🚀 |
e4e0125 to
40c438c
Compare
|
I looked into the broken links page and it seems quite different on If you have the bandwidth to update this PR to handle those changes that would be wonderful, but if not I'd consider creating the
|
|
I will check and update to the new UI :) |
7e0b6c7 to
e738f79
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
I reached out on Slack and got a design review for the table change
|
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all the work on this one. I know this MFE is huge and it hasn't been the fastest review process, but I'm incredibly happy with the results here.
🎉 Amazing Job 🎉
3c52a28
into
openedx:master-design-tokens






Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.Description
This PR adds the support to css variables and paragon design tokens. Focused on
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
You can navigate the different authoring sections in the sandbox.
Other information
Include anything else that will help reviewers and consumers understand the change.