Skip to content

Conversation

@dcoa
Copy link
Contributor

@dcoa dcoa commented Mar 24, 2025

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description

This PR adds the support to css variables and paragon design tokens. Focused on

  • Update deprecated components (Truncate, Table and CheckBox).
  • Replace saas variables with css variables.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

You can navigate the different authoring sections in the sandbox.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 24, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 24, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 24, 2025
@dcoa dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 24, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 24, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 4f1d6cb to 8554eb9 Compare March 24, 2025 20:48
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 9bc8e3f to fe31d59 Compare April 2, 2025 09:54
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 7e0fe48 to d8def1c Compare April 2, 2025 11:07
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from d8def1c to a3556d1 Compare April 2, 2025 20:38
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 9b37787 to e4e0125 Compare April 3, 2025 00:58
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master-design-tokens@9a2dc80). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             master-design-tokens    #1758   +/-   ##
=======================================================
  Coverage                        ?   93.82%           
=======================================================
  Files                           ?     1150           
  Lines                           ?    24056           
  Branches                        ?     5194           
=======================================================
  Hits                            ?    22570           
  Misses                          ?     1409           
  Partials                        ?       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa changed the title [WIP] feat: add design tokens support feat: add design tokens support Apr 3, 2025
@dcoa dcoa requested a review from brian-smith-tcril April 3, 2025 01:14
@dcoa dcoa marked this pull request as ready for review April 3, 2025 01:14
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from e4e0125 to 40c438c Compare April 13, 2025 23:51
@brian-smith-tcril
Copy link
Contributor

brian-smith-tcril commented May 11, 2025

I looked into the broken links page and it seems quite different on master vs this branch. It looks like that is because #1910 is on master. I'm sorry I didn't get a chance to look into the DataTable vs deprecated Table sooner - it looks like I missed it by 3 days.

If you have the bandwidth to update this PR to handle those changes that would be wonderful, but if not I'd consider creating the master-design-tokens branch from cdb8016 (the commit immediately before that redesign landed.)

master

Screenshot From 2025-05-10 18-53-39
Screenshot From 2025-05-10 18-53-43

This PR

Screenshot From 2025-05-10 19-49-17
Screenshot From 2025-05-10 19-49-31

@dcoa
Copy link
Contributor Author

dcoa commented May 12, 2025

I will check and update to the new UI :)

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 7e0b6c7 to e738f79 Compare May 12, 2025 11:17
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril
Copy link
Contributor

Thank you so much for updating this!

Here are some new comparison screenshots:

master

Screenshot From 2025-05-10 18-53-39
Screenshot From 2025-05-10 18-53-43

This PR

image
image

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to In Eng Review in Contributions May 12, 2025
@brian-smith-tcril
Copy link
Contributor

I reached out on Slack and got a design review for the table change

Sam Daitzman
Looks great to me! The alternate table row color is easier to read, and most of the other changes are minor (and positive). Thanks for tagging me to take a look 😄

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all the work on this one. I know this MFE is huge and it hasn't been the fastest review process, but I'm incredibly happy with the results here.

🎉 Amazing Job 🎉

@brian-smith-tcril brian-smith-tcril changed the base branch from master to master-design-tokens May 12, 2025 20:21
@brian-smith-tcril brian-smith-tcril merged commit 3c52a28 into openedx:master-design-tokens May 12, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions May 12, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants