Skip to content

feat: library unit sidebar [FC-0083]#1762

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4050/library-unit-sidebar
Apr 7, 2025
Merged

feat: library unit sidebar [FC-0083]#1762
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4050/library-unit-sidebar

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Mar 25, 2025

Description

This PR implements the placeholder for the Unit Sidebar.

Supporting information

Implements #1617
Depends on #1754

Testing instructions

  • Open a library with some units
  • Click on the unit and check that the sidebar opens
  • Copy the URL with the sidebar open and reload, to check if the sidebar is open correctly
  • Do the same using the Units tab
  • Also, check that you can rename the units using the sidebar

__
Private ref: FAL-4050

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 25, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 25, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 25, 2025
@rpenido rpenido changed the title Rpenido/fal 4050/library unit sidebar feat: library unit sidebar Mar 25, 2025
@rpenido rpenido force-pushed the rpenido/fal-4050/library-unit-sidebar branch 4 times, most recently from 8c37d84 to e66bebc Compare March 27, 2025 17:36
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 1, 2025
@rpenido rpenido force-pushed the rpenido/fal-4050/library-unit-sidebar branch 7 times, most recently from 9e286c7 to 203e55b Compare April 2, 2025 17:43
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 99.24242% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.49%. Comparing base (55344bc) to head (3105f51).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
...ibrary-authoring/common/context/SidebarContext.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   93.47%   93.49%   +0.02%     
==========================================
  Files        1120     1128       +8     
  Lines       22730    22882     +152     
  Branches     4823     4947     +124     
==========================================
+ Hits        21246    21394     +148     
+ Misses       1416     1412       -4     
- Partials       68       76       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4050/library-unit-sidebar branch 3 times, most recently from e5856b2 to efa3230 Compare April 2, 2025 19:33
@rpenido rpenido changed the title feat: library unit sidebar feat: library unit sidebar [FC-0083] Apr 2, 2025
@rpenido rpenido force-pushed the rpenido/fal-4050/library-unit-sidebar branch 2 times, most recently from f8c7bce to 534078c Compare April 2, 2025 20:03
@rpenido rpenido marked this pull request as ready for review April 2, 2025 20:15
@rpenido rpenido force-pushed the rpenido/fal-4050/library-unit-sidebar branch from 534078c to 7410cf7 Compare April 2, 2025 20:24
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido The sidebar state (unit and collection) is not preserved on refreshing page, everything else looks good.

@rpenido
Copy link
Contributor Author

rpenido commented Apr 3, 2025

@rpenido The sidebar state (unit and collection) is not preserved on refreshing page, everything else looks good.

Good catch @navinkarkera.
Fixed here: 7d5f9fd

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will merge it on Monday morning

@rpenido
Copy link
Contributor Author

rpenido commented Apr 5, 2025

Sorry @ChrisChV!
Hmm.. I think I found another bug: if you have a Collection/Unit selected and switch to the Collections/Unit tab, you lose the current selection on the URL.

I will try to fix it before you merge. If I didn't fix it on time, I suggest you merge it, and I will create a follow-up PR on this same ticket.

@ChrisChV
Copy link
Contributor

ChrisChV commented Apr 7, 2025

I will try to fix it before you merge. If I didn't fix it on time, I suggest you merge it, and I will create a follow-up PR on this same ticket.

Hi @rpenido Were you able to fix it? I'm thinking of merging your PR in an hour.

@rpenido
Copy link
Contributor Author

rpenido commented Apr 7, 2025

Hi @rpenido Were you able to fix it? I'm thinking of merging your PR in an hour.

Just fixed it! 😅

@ChrisChV ChrisChV merged commit 68d62cd into openedx:master Apr 7, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 7, 2025
@ChrisChV ChrisChV deleted the rpenido/fal-4050/library-unit-sidebar branch April 7, 2025 16:51
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

Comments