feat: library unit sidebar [FC-0083]#1762
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8c37d84 to
e66bebc
Compare
9e286c7 to
203e55b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
+ Coverage 93.47% 93.49% +0.02%
==========================================
Files 1120 1128 +8
Lines 22730 22882 +152
Branches 4823 4947 +124
==========================================
+ Hits 21246 21394 +148
+ Misses 1416 1412 -4
- Partials 68 76 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e5856b2 to
efa3230
Compare
f8c7bce to
534078c
Compare
534078c to
7410cf7
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
@rpenido The sidebar state (unit and collection) is not preserved on refreshing page, everything else looks good.
Good catch @navinkarkera. |
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good. I will merge it on Monday morning
|
Sorry @ChrisChV! I will try to fix it before you merge. If I didn't fix it on time, I suggest you merge it, and I will create a follow-up PR on this same ticket. |
Hi @rpenido Were you able to fix it? I'm thinking of merging your PR in an hour. |
Just fixed it! 😅 |
Description
This PR implements the placeholder for the Unit Sidebar.
Supporting information
Implements #1617
Depends on #1754
Testing instructions
Unitstab__
Private ref: FAL-4050