fix: manage access modal on duplicated xblock

[ihor-romaniuk]

Description

The xBlock Manage Access modal doesn't open on duplicated xBlock without page reload.

Step to reproduce:

• open CMS
• open course
• open section > subsection > units
• add unit
• dublicate unit
• click on the unit menu > manage access
  
• access modal doesn't display
• refresh page and click on the unit menu > manage access
• access modal displays

Backports:

• teak release fix: manage access modal on duplicated xblock #1874

Other information

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_NEW_MFES:
  authoring:
    port: 18000
    repository: https://github.com/raccoongang/frontend-app-course-authoring.git
    version: romaniuk/fix/manage-access-modal-on-duplicated-xblock

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (855b44f) to head (9fc5672).
Report is 20 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
+ Coverage   93.77%   93.79%   +0.02%     
==========================================
  Files        1146     1146              
  Lines       23905    23900       -5     
  Branches     5043     5144     +101     
==========================================
+ Hits        22416    22417       +1     
+ Misses       1421     1406      -15     
- Partials       68       77       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[arbrandes]

I cannot reproduce the issue with the provided instructions. I tried it in teak.demo.edly.io (which is running teak.master), and tried it in a local dev deployment of master. In both cases I'm able to duplicate an HTML block on a new course, and immediately after saving the duplicate, if I click on the Manage Access button, the modal seems to show correctly (albeit empty).

I did, however, notice something weird. I edited the body text in the duplicate HTML block before clicking Save. After saving, the content I edited shows in the block with a title of "Text", and the block with a title "Duplicate of 'Text'" contains the original, unaltered text.

Anyway... Any idea what else I can try to reproduce the reported issue?

[PKulkoRaccoonGang]

I cannot reproduce the issue with the provided instructions. I tried it in teak.demo.edly.io (which is running teak.master), and tried it in a local dev deployment of master. In both cases I'm able to duplicate an HTML block on a new course, and immediately after saving the duplicate, if I click on the Manage Access button, the modal seems to show correctly (albeit empty).

I was able to reproduce the issue with opening a Manage Access modal window on https://apps.master.openedx.io and sandbox of the recent new PR

Screen.Recording.2025-05-02.at.08.53.22.mov

[arbrandes]

Ok, it seems behavior with the HTML block is a bit wonky independently of this bug. I was able to reproduce the titular issue with the drag-and-drop block, and to confirm that the fix works. I'm going to open a separate issue for the weird HTML block behavior I'm observing.