Skip to content

Conversation

@diana-villalvazo-wgu
Copy link
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented Sep 3, 2025

Description

As part of deprecation of react-unit-test-utils work, as a final PR and cleanup, we did the following tasks:

  • Remove general mocks for react, paragon and i18n, when needed we added mock on the required test (only 2 test cases for react).
  • Remove unmocks related to react, paragon and i18n on the tests that were fixed as part of this initiative.
  • We fixed some tests that were checking for FormattedMessage instead of a real text coming from messages.
  • During this work we decided to refactor a repetitive code to render with IntlProvider, so we created the wrapper on testUtils to reuse on tests and avoid code be repetitive.
  • We made some small improvements to use screen instead of picking selectors from the render, to follow a same syntax across the repo and following best practices from testing library.
  • Remove remaining snapshots.
  • Remove react-unit-test-utils package.

Support Information

Closes #423
Closes #424

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 3, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 3, 2025

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @codewithemad.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 3, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Sep 3, 2025
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b10aa63) to head (9eab790).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #465   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1080      1080           
  Branches       160       160           
=========================================
  Hits          1080      1080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Waiting on Author in Contributions Sep 3, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review September 4, 2025 14:24
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Sep 4, 2025
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

It's great to see all this getting cleaned up!

Couple little notes, once those are resolved this should be good to go!

expect(rubricCard).toBeInTheDocument();
expect(footer).toBeInTheDocument();
renderWithIntl(<Rubric />);
const rubricCardTitle = screen.getByRole('heading', { name: /rubric/i });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i change this to use testing library queries

@brian-smith-tcril brian-smith-tcril merged commit a579455 into openedx:master Sep 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Sep 5, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the 423/cleanup branch September 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Getting rid of react-unit-test-utils utils and use rtl Transform snapshots into rtl tests

3 participants