From 01ada0b49fd877b057406f6d4b9c3b0a821b4e65 Mon Sep 17 00:00:00 2001
From: Agrendalath <piotr@surowiec.it>
Date: Tue, 1 Jun 2021 19:30:34 +0200
Subject: [PATCH] fix: handle opening verticals in new tabs with the "View In
 Studio" button

#24020 introduced a workaround for viewing the current vertical in Studio
However, replacing `window.location.href` on `click` did not support opening
it in a new tab.
---
 lms/templates/preview_menu.html | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/lms/templates/preview_menu.html b/lms/templates/preview_menu.html
index b9d5d223ddeb..fa26e6bc4f06 100644
--- a/lms/templates/preview_menu.html
+++ b/lms/templates/preview_menu.html
@@ -107,7 +107,7 @@
                 </a>
                 <script type="text/javascript">
                   $(function () {
-                      $('.wrapper-preview-menu a.view-in-studio').click(function (event) {
+                      $('.wrapper-preview-menu a.view-in-studio').focus(function (event) {
                           /*
                           When we start rendering this template, we
                           don't yet have a vertical in the context
@@ -115,9 +115,11 @@
                           if this is even on a unit-level page),
                           so we dynamically lookup the vertical element in
                           the DOM and use its data-* attributes to
-                          construct a Studio link directly to this unit.
-                          If no vertical is present, the link behaves as
-                          normal.
+                          construct a Studio link directly to this unit
+                          and replace the href attribute with it. If no
+                          vertical is present, the link directs to the
+                          course outline page in Studio.
+
                           */
                           var verticals = $('.xblock-student_view-vertical');
                           if (verticals.length > 0) {
@@ -127,12 +129,8 @@
                                 'container',
                                 blockId,
                               ].join('/');
-                              window.location.href = url;
-                              return false;
+                              $(this).attr("href", url);
                           }
-                          // There's no vertical, so let the event
-                          // bubble up, ie, work like a normal link.
-                          return true;
                       });
                     });
                   </script>