From c0761b807d09d6768acce28094daf4d3f4279a2b Mon Sep 17 00:00:00 2001 From: Asespinel Date: Mon, 1 Dec 2025 11:33:18 -0500 Subject: [PATCH 1/2] fix: Course search pill not cleared when text deleted --- lms/static/js/discovery/discovery_factory.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lms/static/js/discovery/discovery_factory.js b/lms/static/js/discovery/discovery_factory.js index d26841f86fca..836f111f5755 100644 --- a/lms/static/js/discovery/discovery_factory.js +++ b/lms/static/js/discovery/discovery_factory.js @@ -30,9 +30,12 @@ } listing = new CoursesListing({model: courseListingModel}); - dispatcher.listenTo(form, 'search', function(query) { - form.showLoadingIndicator(); - search.performSearch(query, filters.getTerms()); + dispatcher.listenTo(form, "search", function (query) { + form.showLoadingIndicator(); + if (!query || query.trim() === "") { + filters.remove("search_query"); + } + search.performSearch(query, filters.getTerms()); }); dispatcher.listenTo(refineSidebar, 'selectOption', function(type, query, name) { From 0f8f5c36b840efc50228059618e0031c599a7165 Mon Sep 17 00:00:00 2001 From: Asespinel <79876430+Asespinel@users.noreply.github.com> Date: Wed, 3 Dec 2025 10:28:19 -0500 Subject: [PATCH 2/2] chore: fix spacing Co-authored-by: Feanil Patel --- lms/static/js/discovery/discovery_factory.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lms/static/js/discovery/discovery_factory.js b/lms/static/js/discovery/discovery_factory.js index 836f111f5755..0e44d8154a84 100644 --- a/lms/static/js/discovery/discovery_factory.js +++ b/lms/static/js/discovery/discovery_factory.js @@ -31,11 +31,11 @@ listing = new CoursesListing({model: courseListingModel}); dispatcher.listenTo(form, "search", function (query) { - form.showLoadingIndicator(); - if (!query || query.trim() === "") { - filters.remove("search_query"); - } - search.performSearch(query, filters.getTerms()); + form.showLoadingIndicator(); + if (!query || query.trim() === "") { + filters.remove("search_query"); + } + search.performSearch(query, filters.getTerms()); }); dispatcher.listenTo(refineSidebar, 'selectOption', function(type, query, name) {