-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: added missing SCSS variables in design tokens #2364
[BD-46] feat: added missing SCSS variables in design tokens #2364
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2364 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 214 214
Lines 3519 3519
Branches 852 852
=======================================
Hits 3223 3223
Misses 288 288
Partials 8 8 ☔ View full report in Codecov by Sentry. |
37a9568
to
e7bd5bd
Compare
e7bd5bd
to
783d4fb
Compare
position: relative; | ||
width: 100%; | ||
padding-right: calc($gutter * .5); | ||
padding-left: calc($gutter * .5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In these files, we have small changes
For example padding-right: $gutter * .5
to padding-right: calc($gutter * .5)
Brand: edx/brand-edx.org#68 |
1509b7f
to
c2c77e6
Compare
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.0.0-alpha.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
* feat: added missing SCSS variables in design tokens * feat: added grid-gutter-width token
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2347
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist