Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: update design tokens #1748

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 7, 2022

Description

  • use the modify parameter in JSON files to apply SASS functions to CSS variables;
  • replace the map-get function with {path.to.design.token.value} in JSON files;
  • try to replace subtract and add functions with calc;
  • run replace-variables-definition for scss/core/_variables.scss file and try to fix issues with bootstrap.

Deploy Preview

Paragon Design System

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 7, 2022

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2022
@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ed89517
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/637200141bf05400081a621e
😎 Deploy Preview https://deploy-preview-1748--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: update design tokens [BD-46] DRAFT: update design tokens Nov 7, 2022
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Nov 7, 2022
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 36cd214 to f3eb5e3 Compare November 7, 2022 23:59
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/design-tokens@95c6a1b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/design-tokens    #1748   +/-   ##
=====================================================
  Coverage                      ?   90.51%           
=====================================================
  Files                         ?      211           
  Lines                         ?     3713           
  Branches                      ?      872           
=====================================================
  Hits                          ?     3361           
  Misses                        ?      337           
  Partials                      ?       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 47b98af to 5167c37 Compare November 8, 2022 22:41
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 1e0a61f to e79f6c1 Compare November 9, 2022 09:58
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from e79f6c1 to 8d8054f Compare November 9, 2022 11:57
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 8d8054f to fd6d164 Compare November 9, 2022 12:00
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 2e25efa to cd21040 Compare November 9, 2022 13:03
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 94cab5d to 46bdabe Compare November 10, 2022 14:29
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from 46bdabe to a60b460 Compare November 10, 2022 14:32
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: update design tokens [BD-46] feat: update design tokens Nov 10, 2022
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-design-tokens branch from f6de564 to 0c79b76 Compare November 10, 2022 22:54
@viktorrusakov viktorrusakov merged commit 340a6ba into openedx:feat/design-tokens Nov 14, 2022
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants