Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Catalog edx-platform tests that fail, both for Tutor and for Devstack #36

Closed
kdmccormick opened this issue Jan 31, 2022 · 13 comments
Closed
Assignees
Labels
discovery Pre-work to determine if an idea is feasible

Comments

@kdmccormick
Copy link
Collaborator

kdmccormick commented Jan 31, 2022

Context

There are some tests that don't work in Tutor. There are also some tests that don't work in Devstack. For the rollout of Tutor to 2U developers, it would be reasonable to ensure that the tests that pass in Devstack also pass in Tutor.

To achieve this, we need to catalog which tests currently don't work. In this issue, we focus on edx-platform tests. A future issue will capture tests for IDAs and MFEs.

Acceptance

  • Run all edx-platform test suites (python unit, js unit, python quality, js quality) within both Devstack and Tutor on master.
  • Catalog the tests or suites that fail.
  • Make new issue(s) to fix tests that fail in Tutor but pass in Devstack.

Results

Sheet: https://docs.google.com/spreadsheets/d/1CHiFOh2RpPlljNNF5rltEgOLGpKe1W35oy5Qms0-JXo/edit#gid=0
Issue list: #110

Sheet: https://docs.google.com/spreadsheets/d/1iu-Z3J_P_1m2pGIoTXAqx0YnQ5cJx6k85VnMpRSGvag/edit#gid=778843154
Single issue for devstack parity: #156
Longer-term issue, for resolving all Tutor test failures: openedx/edx-platform#32353

@regisb
Copy link

regisb commented Feb 1, 2022

For the record, here are the instructions on how to run tests in Tutor: https://docs.tutor.overhang.io/dev.html#running-edx-platform-unit-tests

It's really too bad that we have to define these environment variables manually to be able to run the test suite. I wish that we could simply run pytest to run all the unit tests.

@kdmccormick
Copy link
Collaborator Author

Strongly agree @regisb . If possible I think that is something we should fix in edx-platform itself--no sense in complicating Tutor or its docs to work around something that is clearly wrong upstream.

@kdmccormick
Copy link
Collaborator Author

@regisb Based on your comment I split out a separate ticket: https://github.com/overhangio/2u-tutor-adoption/issues/48

@kdmccormick kdmccormick added affects:2u-pilot discovery Pre-work to determine if an idea is feasible labels Feb 16, 2022
@kdmccormick kdmccormick changed the title As a developer, I want to be able to run all tests in Tutor that I could in Devstack Catalog tests that fail for both Tutor and Devstack Feb 16, 2022
@kdmccormick kdmccormick changed the title Catalog tests that fail for both Tutor and Devstack Catalog edx-platform tests that fail, both for Tutor and for Devstack Feb 16, 2022
@kdmccormick kdmccormick moved this from Ungroomed (Kyle) to Groomed in Tutor DevEnv Adoption (OLD BOARD) Feb 16, 2022
@Carlos-Muniz
Copy link

I'm tackling this issue. Feel free to assign it to me!
I'll be running the tests via Tutor's nightly branch.

@Carlos-Muniz
Copy link

@Carlos-Muniz
Copy link

@kdmccormick Completed the xmodule pytests for Tutor and Devstack and recorded it in the spreadsheet, and made new issues for each of the pytest classes.

@kdmccormick
Copy link
Collaborator Author

All issues for fixing tests are collected here: #110

Repository owner moved this from In Progress to Done in Axim Engineering Tasks Sep 16, 2022
@jmakowski1123 jmakowski1123 moved this to Done - To ship in future Named Release in Open edX Roadmap Oct 6, 2022
@jmakowski1123 jmakowski1123 moved this from Done - To ship in future Named Release to To ship in Olive in Open edX Roadmap Oct 6, 2022
@kdmccormick
Copy link
Collaborator Author

Since @Carlos-Muniz last ran these, looks like the set of failing tests has changed. Furthermore, we've realized that the test randomization behavior causes ddt tests to be renamed (based on their order) which caused issues when comparing tests in the spreadsheet. Carlos will be re-running and cataloging the tests.

@kdmccormick kdmccormick reopened this Dec 14, 2022
Repository owner moved this from Done to In Progress in Axim Engineering Tasks Dec 14, 2022
Repository owner moved this from 🚀 Closed to 📋 Refined in Developer Experience Working Group Dec 14, 2022
Repository owner moved this from 🚀 Closed to 🛠️ In Progress in Tutor DevEnv Adoption Dec 14, 2022
@kdmccormick kdmccormick moved this from To ship in Olive to In Progress in Open edX Roadmap Dec 14, 2022
@kdmccormick kdmccormick moved this from 📋 Refined to 🛠️ In Progress in Developer Experience Working Group Dec 14, 2022
@Carlos-Muniz
Copy link

@kdmccormick A new issue #155 has been created for the latest running of pytests in Devstack and Tutor. Issue #110, and related issues can also be closed.

@kdmccormick
Copy link
Collaborator Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discovery Pre-work to determine if an idea is feasible
Projects
None yet
Development

No branches or pull requests

3 participants