You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The serial input buffer in getSettings() can overflow with a long input sequence as the test if (idx<64) { is incorrect.
The buffer input is 64 characters long, but it should reserve 1 byte for the \0 string terminator. With 0-based addressing that means that only 0-62 are valid character addresses, so the test should be idx<63 to ensure the zero terminator is never overwritten with a character.
The text was updated successfully, but these errors were encountered:
The serial input buffer in
getSettings()
can overflow with a long input sequence as the testif (idx<64) {
is incorrect.The buffer
input
is 64 characters long, but it should reserve 1 byte for the\0
string terminator. With 0-based addressing that means that only 0-62 are valid character addresses, so the test should beidx<63
to ensure the zero terminator is never overwritten with a character.The text was updated successfully, but these errors were encountered: