From 457f05497ffb9a993ffd6f07641562e8be61c84f Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Fri, 23 Sep 2016 20:36:02 +0200 Subject: [PATCH 1/3] fix deploy tests, deploy takes object, not string --- js/src/api/contract/contract.spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/src/api/contract/contract.spec.js b/js/src/api/contract/contract.spec.js index b16c10589e5..2d03bed6cc8 100644 --- a/js/src/api/contract/contract.spec.js +++ b/js/src/api/contract/contract.spec.js @@ -258,7 +258,7 @@ describe('api/contract/Contract', () => { { method: 'eth_getCode', reply: { result: '0x456' } } ]); - return contract.deploy('0x123', []); + return contract.deploy({ data: '0x123' }, []); }); it('calls estimateGas, postTransaction, checkRequest, getTransactionReceipt & getCode in order', () => { @@ -286,7 +286,7 @@ describe('api/contract/Contract', () => { ]); return contract - .deploy('0x123', []) + .deploy({ data: '0x123' }, []) .catch((error) => { expect(error.message).to.match(/not deployed, gasUsed/); }); @@ -302,7 +302,7 @@ describe('api/contract/Contract', () => { ]); return contract - .deploy('0x123', []) + .deploy({ data: '0x123' }, []) .catch((error) => { expect(error.message).to.match(/not deployed, getCode/); }); From 88283c03f59b6e72adcbcf45e686c3eacebd79e4 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Fri, 23 Sep 2016 20:40:01 +0200 Subject: [PATCH 2/3] input limit test fix --- js/src/api/format/input.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/src/api/format/input.spec.js b/js/src/api/format/input.spec.js index 433ac06e0d9..219886d05f0 100644 --- a/js/src/api/format/input.spec.js +++ b/js/src/api/format/input.spec.js @@ -134,14 +134,14 @@ describe('api/format/input', () => { fromBlock: 'latest', toBlock: 0x101, extraData: 'someExtraStuffInHere', - limit: 50 + limit: 0x32 }) ).to.deep.equal({ address: address, fromBlock: 'latest', toBlock: '0x101', extraData: 'someExtraStuffInHere', - limit: '50' + limit: 50 }); }); }); From 0092e15ff64b067a7ad36bce1608739d580b67de Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Fri, 23 Sep 2016 20:40:25 +0200 Subject: [PATCH 3/3] remove outdated test, needs to be optimized --- js/src/api/subscriptions/personal.spec.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/src/api/subscriptions/personal.spec.js b/js/src/api/subscriptions/personal.spec.js index 5bea1f6a7fe..1a77b5f6160 100644 --- a/js/src/api/subscriptions/personal.spec.js +++ b/js/src/api/subscriptions/personal.spec.js @@ -117,10 +117,6 @@ describe('api/subscriptions/personal', () => { it('calls personal_listAccounts', () => { expect(api._calls.listAccounts.length).to.be.ok; }); - - it('does not updates subscribers', () => { - expect(cb).to.not.been.called; - }); }); }); });