Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backport #8099 to beta #8132

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Backport #8099 to beta #8132

merged 2 commits into from
Apr 4, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 16, 2018

I created branch during cherry-pick, so the commit message is malformed, but it's only a backport

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. labels Mar 16, 2018
@tomusdrw
Copy link
Collaborator

Please check binary size before merging, if it increases the size we should not backport it to beta.

@debris
Copy link
Collaborator Author

debris commented Mar 19, 2018

it's 63,7 mb

du -k target/release/parity
65244	target/release/parity

@andresilva
Copy link
Contributor

andresilva commented Mar 19, 2018

I tested the size by merging this PR into #8136. On macOS, after stripping binaries:

Before: -rwxr-xr-x 1 andre staff 51827304 Mar 19 18:55 target/release/parity
After: -rwxr-xr-x 1 andre staff 52282412 Mar 19 19:00 target/release/parity

It's still under the 50MB mark but very close.

@tomusdrw
Copy link
Collaborator

@andresilva @debris Let's realease without it for now, and maybe include it in next patch release. Hopefuly by then a lot of people upgrade to a non 50MB limited version so we will have more breathing space with the size.

@tomusdrw tomusdrw removed the A0-pleasereview 🤓 Pull request needs code review. label Apr 4, 2018
@debris debris merged commit fdd03cc into beta Apr 4, 2018
@debris debris deleted the backport_drop_openssl branch April 4, 2018 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants