Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backports for stable 2.0.7 #9648

Merged
merged 16 commits into from
Oct 10, 2018
Merged

Backports for stable 2.0.7 #9648

merged 16 commits into from
Oct 10, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Sep 25, 2018 •
edited by andresilva
Loading

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust. M2-config 📂 Chain specifications and node configurations. labels Sep 25, 2018
@5chdn 5chdn added this to the Patch milestone Sep 25, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 30, 2018
5chdn added 5 commits October 2, 2018 00:14
@5chdn
CI: Remove unnecessary pipes (#9681)
266937d 
* ci: reduce gitlab pipelines significantly

* ci: build pipeline for PR

* ci: remove dead weight

* ci: remove github release script

* ci: remove forever broken aura tests

* ci: add random stuff to the end of the pipes

* ci: add wind and mac to the end of the pipe

* ci: remove snap artifacts

* ci: (re)move dockerfiles

* ci: clarify job names

* ci: add cargo audit job

* ci: make audit script executable

* ci: ignore snap and docker files for rust check

* ci: simplify audit script

* ci: rename misc to optional

* ci: add publish script to releaseable branches

* ci: more verbose cp command for windows build

* ci: fix weird binary checksum logic in push script

* ci: fix regex in push script for windows

* ci: simplify gitlab caching

* docs: align README with ci changes

* ci: specify default cargo target dir

* ci: print verbose environment

* ci: proper naming of scripts

* ci: restore docker files

* ci: use docker hub file

* ci: use cargo home instead of cargo target dir

* ci: touch random rust file to trigger real builds

* ci: set cargo target dir for audit script

* ci: remove temp file

* ci: don't export the cargo target dir in the audit script

* ci: fix windows unbound variable

* docs: fix gitlab badge path

* rename deprecated gitlab ci variables

https://docs.gitlab.com/ee/ci/variables/#9-0-renaming

* ci: fix git compare for nightly builds

* test: skip c++ example for all platforms but linux

* ci: add random rust file to trigger tests

* ci: remove random rust file

* disable cpp lib test for mac, win and beta (#9686)
@5chdn
cleanup ci merge
f860c38
@5chdn
parity: bump clib
66e6819
@5chdn
ci: fix tests
3597886
@5chdn
ci: disable c++ example
035ebdc
@ordian
Copy link
Member

ordian commented Oct 2, 2018

I believe backporting #9638 (fixes problems of #9433) here doesn't make sense, since #9433 is not in stable yet. Same applies to #9608.

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 8, 2018
@5chdn 5chdn mentioned this pull request Oct 9, 2018
Merged
16 tasks
@5chdn 5chdn added the P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. label Oct 9, 2018
asymmetric and others added 4 commits October 9, 2018 15:16
@asymmetric @5chdn
Docker: run as parity user (#9689)
6ea1af3
@5chdn
CI: Skip docs job for nightly (#9693)
6690100 
* ci: force-tag wiki changes

* ci: force-tag wiki changes

* ci: skip docs job for master and nightly

* ci: revert docs job checking for nightly tag

* ci: exclude docs job from nightly builds in gitlab script
@niklasad1 @5chdn
fix (light/provider) : Make read_only executions read-only (#9591)
57030ce 
* `ExecutionsRequest` from light-clients as read-only

This changes so all `ExecutionRequests` from light-clients are executed
as read-only which the `virtual``flag == true ensures.

This boost up the current transaction to always succeed

Note, this only affects `eth_estimateGas` and `eth_call` AFAIK.

* grumbles(revert renaming) : TransactionProof

* grumbles(trace) : remove incorrect trace

* grumbles(state/prove_tx) : explicit `virt`

Remove the boolean flag to determine that a `state::prove_transaction`
whether it should be executed in a virtual context or not.

Because of that also rename the function to
`state::prove_transction_virtual` to make more clear
@andresilva @5chdn
ethcore: fix detection of major import (#9552)
43f38a5 
* sync: set state to idle after sync is completed

* sync: refactor sync reset
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 9, 2018
5chdn and others added 2 commits October 9, 2018 16:42
@5chdn 5chdn added P0-dropeverything 🌋 Everyone should address the issue now. and removed P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 10, 2018
@debris @andresilva
ethcore-io retries failed work steal (#9651)
e7af1c0 
* ethcore-io uses newer version of crossbeam && retries failed work steal

* ethcore-io non-mio service uses newer crossbeam
niklasad1
niklasad1 reviewed Oct 10, 2018
View reviewed changes
scripts/gitlab/build-unix.sh
@@ -0,0 +1,46 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have #!/usr/env bash here instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Need to be fixed in master though

@andresilva andresilva added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 10, 2018
@5chdn 5chdn merged commit 93b25d5 into stable Oct 10, 2018
@5chdn 5chdn deleted the a5-stable-207 branch October 10, 2018 15:34
@ddorgan ddorgan mentioned this pull request Nov 7, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust. P0-dropeverything 🌋 Everyone should address the issue now.
Projects
None yet
Milestone
Patch
Development

Successfully merging this pull request may close these issues.
8 participants
@5chdn @ordian @andresilva @niklasad1 @varasev @debris @asymmetric @tomaka