Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary network attribute #84

Merged
merged 1 commit into from
May 31, 2019
Merged

Remove unnecessary network attribute #84

merged 1 commit into from
May 31, 2019

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented May 31, 2019

Remove unnecessary network attribute from functions.json.

Signed-off-by: Richard Gee richard@technologee.co.uk

@rgee0 rgee0 mentioned this pull request May 31, 2019
Merged
12 tasks
@alexellis
Copy link
Member

Are any present in store.json?

@rgee0
Remove unnecessary network attribute
6a6323f 
Signed-off-by: Richard Gee <richard@technologee.co.uk>
@rgee0
Copy link
Contributor Author

rgee0 commented May 31, 2019

Are any present in store.json?

Are there?

@alexellis
Copy link
Member

That's a question for you. I didn't think we were using functions.json yet, or are we?

store*.json does appear to contain some entries to func_functions, can you please cover that as part of this PR?

alexellis
alexellis approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 0f4514c into openfaas:master May 31, 2019
@alexellis alexellis mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgee0 @alexellis