-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(enums): fix enums doctests #1273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
added
the
kind:test
Adding missing tests or correcting existing tests
label
Oct 9, 2024
bonjourmauko
force-pushed
the
test/fix-enums-doctests
branch
from
October 9, 2024 01:17
3f07814
to
8a218e9
Compare
bonjourmauko
force-pushed
the
test/fix-enums-doctests
branch
from
October 9, 2024 01:55
9ca67b3
to
380e3af
Compare
bonjourmauko
force-pushed
the
test/fix-enums-doctests
branch
from
October 9, 2024 02:37
05e9db7
to
6dfc93f
Compare
Merged
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
bonjourmauko
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1272
Fixes #1267
New features
indexed_enums.EnumType
indexed_enums.Enum
Technical changes
Enum.encode
when passing a scalarTypeError
but with an explanation of why it failsEnum.encode
when encoding values not present in the enumEnum.encode
always encoded the first item of itBefore
After