Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feedback button #261

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Remove feedback button #261

merged 1 commit into from
Jul 29, 2022

Conversation

MattiSG
Copy link
Member

@MattiSG MattiSG commented Apr 29, 2022

This changeset removes the floating feedback button that misleadingly looks like a “get help” button, always floating in the lower left corner of the documentation.

Capture d’écran 2022-04-29 à 16 39 28

Rationale

  1. No team actively monitors responses. Actually, until today, no maintainer knew the password to access the service collecting replies.
  2. It is misleading. The drop rate (people clicking on it vs people leaving feedback) is 93% (4-to-60).
  3. In 3 years, this form collected 4 responses, of which only 1 was useful, in 2019. It mentioned broken links, detection of which should be automated. All responses are given below.
Date Time Type Comment
18 Jan 2022 18:57 I didn't find what I was looking for No
10 May 2021 17:09 I didn't find what I was looking for [email hidden] simulation droit aide au logement
19 Jan 2020 13:49 I think there is a mistake g
3 Dec 2019 09:33 Section 3 of https://openfisca.org/doc/ , the web-api and python api links are broken [email hidden]

This was referenced Apr 29, 2022
@MattiSG MattiSG requested review from sandcha and bonjourmauko May 5, 2022 14:10
@nikhilwoodruff
Copy link

Looks like the deploy-preview action fails because of this dependency issue.

@MattiSG
Copy link
Member Author

MattiSG commented Jun 17, 2022

Thanks @nikhilwoodruff! Indeed, all open PRs suffer from this blocking issue. It will be fixed once #264 is reviewed and merged 🙂

@MattiSG
Copy link
Member Author

MattiSG commented Jun 17, 2022

This shouldn't block a review though 😉

No team actively monitors it
In 3 years, it collected 4 responses, of which only 1 was useful (broken link), and it should be automated
@MattiSG MattiSG force-pushed the remove-feedback-button branch from fe066b9 to d99f5d5 Compare June 17, 2022 15:05
Copy link

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @MattiSG what's the convention on approving review and test runs? Is it "merge if approvals and tests pass", or "merge if approvals". Seems like it's the latter.

@MattiSG
Copy link
Member Author

MattiSG commented Jun 17, 2022

Thanks @nikhilwoodruff! All our repositories are set to allow merge only when both tests pass and at least one maintainer approved the PR 🙂 You can find more information on Core's CONTRIBUTING file.

Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MattiSG!

Comment on lines 19 to 20
{%- block bottom_rel_links %}
<a class="actionbutton" title="Did you find what you were looking for?" data-toggle="tooltip" data-placement="top" href="https://openfisca.typeform.com/to/WudIsQ"><i class="fas fa-question"></i></a>
{%- endblock %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 And we are keeping the empty block to override the default block of the guzzle_sphinx_theme v.0.7.11 (the theme is used as template).

@MattiSG MattiSG merged commit 2c9fd5b into master Jul 29, 2022
@MattiSG MattiSG deleted the remove-feedback-button branch July 29, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants