-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feedback button #261
Conversation
Looks like the deploy-preview action fails because of this dependency issue. |
Thanks @nikhilwoodruff! Indeed, all open PRs suffer from this blocking issue. It will be fixed once #264 is reviewed and merged 🙂 |
This shouldn't block a review though 😉 |
No team actively monitors it In 3 years, it collected 4 responses, of which only 1 was useful (broken link), and it should be automated
fe066b9
to
d99f5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @MattiSG what's the convention on approving review and test runs? Is it "merge if approvals and tests pass", or "merge if approvals". Seems like it's the latter.
Thanks @nikhilwoodruff! All our repositories are set to allow merge only when both tests pass and at least one maintainer approved the PR 🙂 You can find more information on Core's CONTRIBUTING file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MattiSG!
{%- block bottom_rel_links %} | ||
<a class="actionbutton" title="Did you find what you were looking for?" data-toggle="tooltip" data-placement="top" href="https://openfisca.typeform.com/to/WudIsQ"><i class="fas fa-question"></i></a> | ||
{%- endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 And we are keeping the empty block to override the default block of the guzzle_sphinx_theme v.0.7.11 (the theme is used as template).
This changeset removes the floating feedback button that misleadingly looks like a “get help” button, always floating in the lower left corner of the documentation.
Rationale