Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openfisca_survey_manager #265

Merged
merged 2 commits into from
Nov 19, 2024
Merged

update openfisca_survey_manager #265

merged 2 commits into from
Nov 19, 2024

Conversation

clallemand
Copy link
Contributor

Technical changes

  • Update the version of openfisca_survey_manager in dependencies

@clallemand clallemand requested a review from sylvainipp November 8, 2024 15:34
@clallemand
Copy link
Contributor Author

Salut @sylvainipp les tests ne passent plus quand je mets à jour la dépendances à openfisca-survey-manager.
J'ai l'impression que cela vient des changements que tu as fait dans la version 2.3.0 de openfisca-survey-manager. Pourrais tu m'aider dans cette erreur ?

@Lolajossipp Lolajossipp self-requested a review November 8, 2024 15:38
@dusylvain
Copy link

Aucun doute que ça vient de moi, je continuerais à essayer de régler ça lundi. Merci de la remontée du problème.

@sylvainipp
Copy link
Contributor

Ce sera a priori corrigé dans openfisca/openfisca-survey-manager#316

Copy link
Contributor

@sylvainipp sylvainipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Désolé pour le contretemps ! Ca démontre une fois de plus l'utilité des tests. Merci encore pour le repérage de l'erreur !

@clallemand clallemand force-pushed the update_survey_manager branch from 7ec4776 to abb109e Compare November 19, 2024 10:04
@clallemand clallemand merged commit 14fa366 into master Nov 19, 2024
12 checks passed
@clallemand clallemand deleted the update_survey_manager branch November 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants