Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve issue calmar target_entity_count #316

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Solve issue calmar target_entity_count #316

merged 4 commits into from
Nov 18, 2024

Conversation

sylvainipp
Copy link
Contributor

@sylvainipp sylvainipp commented Nov 12, 2024 •
edited
Loading

Technical changes

  • Solve an issue caused by #299 when there is a target_entity_count without variables of the same entity.
  • Correct the CHANGELOG which had two errors.
  • Correct a problem of circular definition by erasing the formula of a weight variable after it is recomputed using calmar.

@sylvainipp sylvainipp mentioned this pull request Nov 12, 2024
Merged
clallemand
clallemand approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@clallemand clallemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour la correction !

@sylvainipp sylvainipp merged commit 104e5ab into master Nov 18, 2024
10 checks passed
@benjello benjello deleted the solve_entity_issue branch November 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clallemand clallemand clallemand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvainipp @clallemand