From 9a1b1b9a7890d396e75cd9125c2241dae20e647d Mon Sep 17 00:00:00 2001 From: SimonBoothroyd Date: Tue, 5 Oct 2021 15:07:11 +0100 Subject: [PATCH] Fix #380 (#387) --- docs/releasehistory.rst | 3 ++- openff/evaluator/storage/localfile.py | 2 +- openff/evaluator/tests/test_storage/test_local.py | 15 +++++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 openff/evaluator/tests/test_storage/test_local.py diff --git a/docs/releasehistory.rst b/docs/releasehistory.rst index de2297aa5..34ea818c1 100644 --- a/docs/releasehistory.rst +++ b/docs/releasehistory.rst @@ -14,7 +14,8 @@ Releases follow the ``major.minor.micro`` scheme recommended by Bugfixes """""""" -* PR `#375 `_: Fix import from collections.abc +* PR `#375 `_: Fix #374 - import from collections.abc +* PR `#387 `_: Fix #380 - Recursion error in local file storage New Features """""""""""" diff --git a/openff/evaluator/storage/localfile.py b/openff/evaluator/storage/localfile.py index e0ca8422e..953a1a67c 100644 --- a/openff/evaluator/storage/localfile.py +++ b/openff/evaluator/storage/localfile.py @@ -18,7 +18,7 @@ class LocalFileStorage(StorageBackend): @property def root_directory(self): """str: Returns the directory in which all stored objects are located.""" - return self.root_directory + return self._root_directory def __init__(self, root_directory="stored_data"): diff --git a/openff/evaluator/tests/test_storage/test_local.py b/openff/evaluator/tests/test_storage/test_local.py new file mode 100644 index 000000000..12fd2c6a8 --- /dev/null +++ b/openff/evaluator/tests/test_storage/test_local.py @@ -0,0 +1,15 @@ +""" +Units tests for openff.evaluator.storage.localfile +""" +import os + +from openff.evaluator.storage import LocalFileStorage + + +def test_root_directory(tmpdir): + + local_storage_path = os.path.join(tmpdir, "stored-data") + local_storage = LocalFileStorage(root_directory=local_storage_path) + + assert os.path.isdir(local_storage_path) + assert local_storage.root_directory == local_storage_path