Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(live) improve UX for document sharing #2511

Closed
NamFra opened this issue Nov 22, 2023 · 0 comments · Fixed by #2512
Closed

(live) improve UX for document sharing #2511

NamFra opened this issue Nov 22, 2023 · 0 comments · Fixed by #2512
Assignees

Comments

@NamFra
Copy link

NamFra commented Nov 22, 2023

Bug Report

Problematic Behavior
The SharedLiveMedia widget has been redesigned, and document sharing and download permissions are now presented more explicitly.

Then

It was necessary to first Stop sharing the current document to display another one (option grayed out).

image

Now

It is now possible to activate the switch for another document while another document is currently being shared.

image

Expected behavior/code
Using the switch on another document should disable the active document without generating an error.

Steps to Reproduce

  1. Create a webinar
  2. Add 2 files using the document sharing widget
  3. Activate the share support switch on one document
  4. Activate the switch on the other document without deactivating the first one
  5. See the error 'Share media update has failed !'"

Environment

  • Marsha version: Staging

Additional context/Screenshots
https://github.com/openfun/marsha/blob/master/src/frontend/packages/lib_video/src/components/common/VideoWidgetProvider/widgets/SharedLiveMedia/index.spec.tsx

live-shared-media-failed.webm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants