-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Replace form components #2437
Conversation
5ef75d6
to
e0b882d
Compare
e0b882d
to
e2c2dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run it yet, but the code looks good.
src/frontend/apps/lti_site/apps/deposit/components/Dashboard/DashboardInstructor/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4409657
to
d031660
Compare
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
<div class="input-group"> | ||
<label>lis_person_name_full</label> | ||
<input type="text" name="lis_person_name_full" value="John Doe"/> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be iso it should also be added to the form managing the iframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d031660
to
1b60d44
Compare
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
Cunningham uprade to 1.3 (which needs a fix in our codebase) is managed in another PR (#2437).
Upgrade to cunningham@1.3.1, this version fix somes issues and add new usefull css properties.
Component to display an error message in a box with an appropriate icon and a message.
The upgrade to Cunningham highlighted a few issues with the LicenseSelect component, the refacto displays the state of the component in a more explicit way.
In some cases we want to be able to change the fullname of the user, to do so, we change the input from hidden to text.
In order to do the transition to the cunningham design system, we replace the grommet CheckBox component with the cunningham Checkbox components.
In order to do the transition to the cunningham design system, we replace the grommet Pagination component with the cunningham Pagination components.
1b60d44
to
ec5238c
Compare
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Added - Generic video LTI url - Display complete error message in frontend - Generic classroom LTI url - Generic LTI cartridge (xml configuration) - Display LTI warning message for generic urls regarding course copy - configure homepage banner using SiteConfig model - setting BBB_INVITE_TOKEN_BANNED_LIST - Add transcode_pipeline property to video model Changed - Replace ngrok with localtunnel to serve marsha on a public domain with stable urls and allow to run multiple tunnels at the same time - Replace all the loaders by Cunningham Loader (#2436) - Replace grommet Text (#2427) - Replace grommet Paragraph (#2435) - Remove cross on login image (#2451) - Replace grommet Checkbox and Pagination (#2437) Fixed - Markdown save sent previously saved content - Force to end BBB meeting when creation fail
Purpose
Replace Grommet form components with Cunningham form components.
Proposal
Before merging
Checkbox change
Before
After
Pagination change
Before
After