⚡️optimize bundle #2528
Merged
⚡️optimize bundle #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/optimize-bundle
branch
8 times, most recently
from
d969ff1
to
652b48a
Compare
AntoLC
force-pushed
the
feature/anthony/optimize-bundle
branch
from
652b48a
to
fc883d9
Compare
Add commands to be able to analyze the bundle size of our apps to see which packages are taking up the most space.
AntoLC
force-pushed
the
feature/anthony/optimize-bundle
branch
from
fc883d9
to
10f187f
Compare
@faker-js/faker is a big package, it weights a lot in the bundle size of our apps, and we only use it for tests. In order to optimize the bundle size, we separate the tests modules from the main package.
@faker-js/faker is a big package, it weights a lot in the bundle size of our apps, and we only use it for tests. In order to optimize the bundle size, we separate the tests modules from the main package.
@faker-js/faker is a big package, it weights a lot in the bundle size of our apps, and we only use it for tests. In order to optimize the bundle size, we separate the tests modules from the main package.
The webpack config was not set up to tree shake mjs files. In our case, the full index.mjs of cunningham was being included in the bundle. This commit fixes that.
We need css files and font from the Cunningham packages to style our app, but the css was included directly in the js bundle, which was not optimal. The css is now in a separate file, which is loaded in the html template. This allows the browser to cache the css file and improves the loading time of the page.
AntoLC
force-pushed
the
feature/anthony/optimize-bundle
branch
from
10f187f
to
256d9ad
Compare
lunika
approved these changes
Dec 11, 2023
lunika
added a commit
that referenced
this pull request
Jun 24, 2024
Added - Add scaleway storage configuration - Add Peertube pipeline to VOD - Celery task queue - Refactor video S3 deletion - Add thumbnail celery task - Add shared live media celery task - Add timed text track celery task - Add form submission with enter key when entering a classroom - Persist username used on classroom join Changed - Replace CRA by Vite (#2530) - Replace grommet Image and Grid component (#2518) - Optimized apps bundle (#2528) - Launch transcoding through a celery task Fixed - Correctly set startime with filtering medialive logs - Remove non existing fields in PortabilityRequestAdmin - Correctly send xapi statement to a configured LRS - Correctly send xapi video download statements
lunika
added a commit
that referenced
this pull request
Jun 26, 2024
Added - Add scaleway storage configuration - Add Peertube pipeline to VOD - Celery task queue - Refactor video S3 deletion - Add thumbnail celery task - Add shared live media celery task - Add timed text track celery task - Add form submission with enter key when entering a classroom - Persist username used on classroom join Changed - Replace CRA by Vite (#2530) - Replace grommet Image and Grid component (#2518) - Optimized apps bundle (#2528) - Launch transcoding through a celery task Fixed - Correctly set startime with filtering medialive logs - Remove non existing fields in PortabilityRequestAdmin - Correctly send xapi statement to a configured LRS - Correctly send xapi video download statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The apps bundles size were quite big, 3 problems were identified:
Proposal
Improvment
Standalone main bundle: 7.37mo to 3.62mo (-50%)
LTI index bundle: 5.25mo to 3.82mo (-27%)