📌(backend) pin lxml dependency to 5.2.1 #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lunika you pinned |
kernicPanel
reviewed
Apr 26, 2024
There was a problem hiding this comment.
I think the commit title should be something like unpin lxml and upgrade to 5.2.1
Aside from that, I add @lunika as a reviewer too.
With the constraint on lxml<5, an error on the collectstatic occured about lxml and xmlsec libxml2 versions mismatch. Unpin lxml to the latest release fix this error. We give back renovate the permission to upgrade the package.
lunika
approved these changes
May 2, 2024
|
@wilbrdt the segfault happened when the user was going back from its CAS when logging using shibboleth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With the constraint on lxml<5, an error on the collectstatic occured about lxml
and xmlsec libxml2 versions mismatch.
Proposal
Pin lxml to the latest release fix this error.