Transcript command #2623
Transcript command #2623
Conversation
Default upload timestamp calculation is extracted to UploadableFileMixin to avoid the use of get_source_s3_key to get it.
Renaming transcript util to ease patching.
kernicPanel
force-pushed
the
transcript-command
branch
from
52157df
to
2b41fc7
Compare
As we want to transcript the whole catalog of videos, we need to add a management command.
kernicPanel
force-pushed
the
transcript-command
branch
from
2b41fc7
to
9f984b8
Compare
kernicPanel
requested review from
lunika,
jbpenrath,
jonathanreveille and
wilbrdt
| parser.add_argument("--video-id", type=str) | ||
|
|
||
| def handle(self, *args, **options): | ||
| """Selects a video to transcript and starts the transcription job.""" |
There was a problem hiding this comment.
nit:
| """Selects a video to transcript and starts the transcription job.""" | |
| """Select a video to transcript and start the transcription job.""" |
src/backend/marsha/core/management/commands/transcript_video.py
Outdated
Show resolved
Hide resolved
| try: | ||
| video = Video.objects.get(id=video_id) | ||
| except Video.DoesNotExist: | ||
| self.stdout.write(f"No video matches the provided id: {video_id}") |
There was a problem hiding this comment.
| self.stdout.write(f"No video matches the provided id: {video_id}") | |
| self.stdout.write(f"No video matches with the provided id: {video_id}") |
As the last one is |
| def handle(self, *args, **options): | ||
| """Selects a video to transcript and starts the transcription job.""" | ||
| video_id = options["video_id"] | ||
| if video_id: |
There was a problem hiding this comment.
Could you extract the content of the if and else in private method ?
| if video_id: | ||
| try: | ||
| video = Video.objects.get(id=video_id) | ||
| except Video.DoesNotExist: |
There was a problem hiding this comment.
I don't know if we should catch it or not. IMO I would like to know that the video_id is not valid.
There was a problem hiding this comment.
A message is displayed, and the script is stopped.
except Video.DoesNotExist:
self.stdout.write(f"No video found with id {video_id}")
return
There was a problem hiding this comment.
If the video_id is invalid (not a uuid) another message will be displayed, and the script will be also stopped.
There was a problem hiding this comment.
Yes but this command will be probably trigger by another one, especially if the video_id optional argument will be used. And we will have no idea that is has fail
There was a problem hiding this comment.
I don't like nested command calls, especially in this case where the main logic only calls
from marsha.core.utils.transcript_utils import transcript
transcript(video)
We have to talk about whole catalog transcription.
| @@ -64,6 +64,12 @@ def is_ready_to_show(self): | |||
| """ | |||
| return self.uploaded_on is not None | |||
|
|
|||
| def uploaded_on_stamp(self): | |||
There was a problem hiding this comment.
Could you add tests on this new method ?
And IMO you are changing the behavior already implemented. Never the timestamp is computed when the uploaded_on is not set.
There was a problem hiding this comment.
In which case of this commit do we compute a timestamp if updloaded_on doesn't exists ?
Here, we only extract to_timestamp(self.uploaded_on) in his own function.
|
|
||
|
|
||
| @patch.object(transcript_video, "transcript") | ||
| class TranscriptVideoTestCase(TestCase): |
There was a problem hiding this comment.
A test case is missing :
Should call transcript function if the video has a subtitle or caption but no transcript.
Purpose
Adds a transcription command.