-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schema: unknown keywords #855
Comments
Read the section "What is being done to soften the blow?" Currently we use keywords with a prefix "x-ogc-" for custom keywords, but we monitor the discussion and will change that to whatever mechanism the JSON Schema group will decide. |
I have read it, but the examples I had seen in presentations didn't had the prefix (yet?). |
All custom keywords had the "x-ogc" prefix from the start, so maybe the examples you have seen are incorrect. See the discussion, which already has the following:
|
@m-mohr I guess you were talking about These should probably be prefixed with cc @joanma747 |
Yes, indeed! |
While I'm completely in favour of extending JSON schema, one can argue that what you see in https://schemas.opengis.net/ogcapi/tiles/part1/1.0/openapi/schemas/tms/propertiesSchema.yaml is not extending JSON Schema. This is actually a JSON schema that defines an object that has no predefined properties but can have extra properties, and all of them shall be objects with a predefined list of properties. Some of these properties are copied from the JSON Schema and some others are "new" and "invented" by us (actually they are copied from Sensor Things API). Since this JSON schema define how to define the " Attributes of the features or rangetypes of a coverage", you can argue that this is a metaschema and is extending JSON Schema. This is a matter of opinion. If we agree this is a metaschema, then, we would adopt the extension mechanism (the one that is under discussion now). I'm experimenting with what is suggested by: |
Has the planned change in JSON Schema to disallow unknown keywords any effect on OGC APIs?
https://json-schema.org/blog/posts/the-last-breaking-change
I've seen @jerstlouis recently showing some schemas for Coverages (based on Features - Part 5) for example, which included custom keywords and I think I've also seen this in Processes. (We also use it in openEO.)
This is more an issue to make people aware of a potential breaking change coming in once new JSON Schema versions may get adopted.
The text was updated successfully, but these errors were encountered: