Issue 178 - Move 'created' and 'updated' fields from the record to the links pointing to the representation of the record. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from master.
from the record properties to links actually pointing to the representations of the resource.
m-mohr
reviewed
Sep 14, 2022
core/examples/json/record.json
Outdated
| @@ -32,8 +32,8 @@ | |||
| ] | |||
| }, | |||
| "properties": { | |||
| "recordCreated": "2021-02-08", | |||
| "recordUpdated": "2021-02-08", | |||
| "created": "2021-02-08", | |||
There was a problem hiding this comment.
All the values for created and updated in the examples are invalid, I think.
The spec says they are "datetime"s, but the examples are "date"s only. So I think it should be something like "2021-02-08T00:00:00Z"
|
LGTM except that the dates in the examples should be valid datetimes. |
|
LGTM, thanks! |
|
28-NOV-2022: Will merge once I resolve the conflicts and @tomkralidis can close his issue once he has had a chance to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement change discussed at the Sept. 2022 OGC Metadata Code Sprint.