Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker/awscli): upgrade to python3 and install python3-dev #1140

Merged
merged 2 commits into from
Apr 19, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(dockerfile): install python2-dev where awscli is needed
A recent change (not sure what) started causing `pip install awscli` to
fail without the python2-dev package.

Install it to fix the build errors.

Travis build log: https://travis-ci.com/github/opengovsg/postmangovsg/jobs/498665286
zwliew committed Apr 15, 2021
commit e2dcbf92ba1ce08cc7c581c990bbda701b890e9f
4 changes: 2 additions & 2 deletions backend/Dockerfile
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ FROM node:12-alpine

# required for node-gyp
RUN apk update && apk upgrade && apk add --no-cache --virtual builds-deps build-base \
g++ make python tini
g++ make python tini python2-dev

RUN apk add py-pip && apk add jq

@@ -28,4 +28,4 @@ RUN ["chmod", "+x", "docker-entrypoint.sh"]

EXPOSE 4000
ENTRYPOINT [ "tini", "--" ]
CMD ["./docker-entrypoint.sh"]
CMD ["./docker-entrypoint.sh"]
4 changes: 2 additions & 2 deletions worker/Dockerfile
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ FROM node:12-alpine

# required for node-gyp
RUN apk update && apk upgrade && apk add --no-cache --virtual builds-deps build-base \
g++ make python tini
g++ make python tini python2-dev

RUN apk add py-pip && apk add jq

@@ -28,4 +28,4 @@ RUN ["chmod", "+x", "docker-entrypoint.sh"]

EXPOSE 4000
ENTRYPOINT [ "tini", "--" ]
CMD ["./docker-entrypoint.sh"]
CMD ["./docker-entrypoint.sh"]