From 18368a269113f1f38e7905abd5d77f841a5d4447 Mon Sep 17 00:00:00 2001 From: Christian Wild Date: Fri, 2 Dec 2022 20:34:11 +0100 Subject: [PATCH] [asuswrt] Apply suggestions from code review Co-authored-by: Wouter Born Signed-off-by: Christian Wild --- bom/openhab-addons/pom.xml | 5 +++++ bundles/org.openhab.binding.asuswrt/README.md | 2 +- .../src/main/feature/feature.xml | 2 +- .../src/main/resources/OH-INF/binding/binding.xml | 2 +- .../src/main/resources/OH-INF/i18n/asuswrt.properties | 2 +- .../tapocontrol/internal/TapoControlHandlerFactory.java | 3 +-- bundles/pom.xml | 6 +----- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/bom/openhab-addons/pom.xml b/bom/openhab-addons/pom.xml index be5f6fa78569d..33896a62b039c 100644 --- a/bom/openhab-addons/pom.xml +++ b/bom/openhab-addons/pom.xml @@ -116,6 +116,11 @@ org.openhab.binding.astro ${project.version} + + org.openhab.addons.bundles + org.openhab.binding.asuswrt + ${project.version} + org.openhab.addons.bundles org.openhab.binding.atlona diff --git a/bundles/org.openhab.binding.asuswrt/README.md b/bundles/org.openhab.binding.asuswrt/README.md index 271d7799227b3..4702c86abf427 100644 --- a/bundles/org.openhab.binding.asuswrt/README.md +++ b/bundles/org.openhab.binding.asuswrt/README.md @@ -4,7 +4,7 @@ This binding adds support to control get informations from ASUS-Router (Copyrigh ## Supported Things -Binding supports ASUS-Router with AsusWRT or -AsusWRT-Merlin Firmware. +This binding supports ASUS routers with Asuswrt or [Asuswrt-Merlin](https://www.asuswrt-merlin.net/) firmware. Firmware 5.x.x (some DSL models) is NOT supported (not AsusWRT). | ThingType | Name | Descripion | diff --git a/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml b/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml index 2c40f7fec15fa..73416289caf02 100644 --- a/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml +++ b/bundles/org.openhab.binding.asuswrt/src/main/feature/feature.xml @@ -2,7 +2,7 @@ mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features - + openhab-runtime-base mvn:org.openhab.addons.bundles/org.openhab.binding.asuswrt/${project.version} diff --git a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml index 82767fae960d2..33ddbdbf0d163 100644 --- a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml +++ b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/binding/binding.xml @@ -4,6 +4,6 @@ xsi:schemaLocation="https://openhab.org/schemas/binding/v1.0.0 https://openhab.org/schemas/binding-1.0.0.xsd"> Asuswrt Binding - Binding for your asus routers (asuswrt / asuswrt-merlin only) + Binding for ASUS routers (Asuswrt / Asuswrt-Merlin only) diff --git a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties index bfebf0cb8b844..5b32cfab2dbb6 100644 --- a/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties +++ b/bundles/org.openhab.binding.asuswrt/src/main/resources/OH-INF/i18n/asuswrt.properties @@ -1,7 +1,7 @@ # binding binding.asuswrt.name = Asuswrt Binding -binding.asuswrt.description = Binding for your asus routers (asuswrt / asuswrt-merlin only) +binding.asuswrt.description = Binding for ASUS routers (Asuswrt / Asuswrt-Merlin only) # thing types diff --git a/bundles/org.openhab.binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java b/bundles/org.openhab.binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java index da38ba61b841c..f24fda61759ae 100644 --- a/bundles/org.openhab.binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java +++ b/bundles/org.openhab.binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java @@ -56,8 +56,7 @@ public class TapoControlHandlerFactory extends BaseThingHandlerFactory { @Activate public TapoControlHandlerFactory() { // create new httpClient - SslContextFactory.Client sslContextFactory = new SslContextFactory.Client(); - httpClient = new HttpClient(sslContextFactory); + httpClient = new HttpClient(new SslContextFactory.Client()); httpClient.setFollowRedirects(false); httpClient.setMaxConnectionsPerDestination(HTTP_MAX_CONNECTIONS); httpClient.setMaxRequestsQueuedPerDestination(HTTP_MAX_QUEUED_REQUESTS); diff --git a/bundles/pom.xml b/bundles/pom.xml index 754c581605c3b..502c48c008b8c 100644 --- a/bundles/pom.xml +++ b/bundles/pom.xml @@ -187,7 +187,6 @@ org.openhab.binding.jablotron org.openhab.binding.jeelink org.openhab.binding.jellyfin - org.openhab.binding.juicenet org.openhab.binding.kaleidescape org.openhab.binding.keba org.openhab.binding.km200 @@ -218,7 +217,6 @@ org.openhab.binding.max org.openhab.binding.mcd org.openhab.binding.mcp23017 - org.openhab.binding.meater org.openhab.binding.mecmeter org.openhab.binding.melcloud org.openhab.binding.mercedesme @@ -306,7 +304,6 @@ org.openhab.binding.pushover org.openhab.binding.pushsafer org.openhab.binding.qbus - org.openhab.binding.qolsysiq org.openhab.binding.radiothermostat org.openhab.binding.regoheatpump org.openhab.binding.revogi @@ -368,7 +365,6 @@ org.openhab.binding.tibber org.openhab.binding.tivo org.openhab.binding.touchwand - org.openhab.binding.tplinkrouter org.openhab.binding.tplinksmarthome org.openhab.binding.tr064 org.openhab.binding.tradfri @@ -655,4 +651,4 @@ - \ No newline at end of file +