diff --git a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeBindingConstants.java b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeBindingConstants.java index a14fe9157f46f..aeed5b1960708 100644 --- a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeBindingConstants.java +++ b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeBindingConstants.java @@ -12,7 +12,6 @@ */ package org.openhab.binding.gree.internal; -import java.math.BigDecimal; import java.util.Collections; import java.util.Set; @@ -170,5 +169,5 @@ public class GreeBindingConstants { * * @See https://github.com/tomikaa87/gree-remote#getting-the-current-temperature-reading-from-the-internal-sensor for more details. */ - public static final BigDecimal CURRENT_TEMP_OFFSET_DEFAULT = new BigDecimal(-40.0); + public static final double INTERNAL_TEMP_SENSOR_OFFSET = -40.0; } diff --git a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeConfiguration.java b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeConfiguration.java index bfd0f5a010729..b5e6fdbe62a47 100644 --- a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeConfiguration.java +++ b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/GreeConfiguration.java @@ -12,8 +12,6 @@ */ package org.openhab.binding.gree.internal; -import static org.openhab.binding.gree.internal.GreeBindingConstants.CURRENT_TEMP_OFFSET_DEFAULT; - import java.math.BigDecimal; import org.eclipse.jdt.annotation.NonNullByDefault; @@ -31,7 +29,7 @@ public class GreeConfiguration { /** * The currentTemperatureOffset is configureable in case the user wants to offset this temperature for calibration of the temperature sensor. */ - public BigDecimal currentTemperatureOffset = CURRENT_TEMP_OFFSET_DEFAULT; + public BigDecimal currentTemperatureOffset = new BigDecimal(0.0); @Override public String toString() { diff --git a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java index b6d0881306737..92b4b95c41239 100644 --- a/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java +++ b/bundles/org.openhab.binding.gree/src/main/java/org/openhab/binding/gree/internal/handler/GreeHandler.java @@ -519,7 +519,7 @@ private void publishChannel(ChannelUID channelUID) { private @Nullable State updateCurrentTemp() throws GreeException { if (device.hasStatusValChanged(GREE_PROP_CURRENT_TEMP_SENSOR)) { - return new DecimalType(device.getIntStatusVal(GREE_PROP_CURRENT_TEMP_SENSOR) + config.currentTemperatureOffset.doubleValue()); + return new DecimalType(device.getIntStatusVal(GREE_PROP_CURRENT_TEMP_SENSOR) + INTERNAL_TEMP_SENSOR_OFFSET + config.currentTemperatureOffset.doubleValue()); } return null; } diff --git a/bundles/org.openhab.binding.gree/src/main/resources/ESH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.gree/src/main/resources/ESH-INF/thing/thing-types.xml index 6b6c8ffb1a811..75bbed7aa0039 100644 --- a/bundles/org.openhab.binding.gree/src/main/resources/ESH-INF/thing/thing-types.xml +++ b/bundles/org.openhab.binding.gree/src/main/resources/ESH-INF/thing/thing-types.xml @@ -36,7 +36,7 @@ true - -40 + 0 Degrees Celsius true