Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Fix exception text in bridge status description (API v2) #15475

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Aug 21, 2023

Related to #15460

Usages:

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
"@text/offline.api2.comm-error.exception [\"" + e.getMessage() + "\"]");

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
"@text/offline.api2.comm-error.exception [\"" + e.getMessage() + "\"]");

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
"@text/offline.api2.comm-error.exception [\"" + e.getMessage() + "\"]");

Documentation: https://www.openhab.org/javadoc/latest/org/openhab/core/thing/i18n/thingstatusinfoi18nlocalizationservice

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 21, 2023
@jlaur jlaur changed the title [hue] Fix exception being displayed in bridge status description [hue] Fix exception text in bridge status description Aug 21, 2023
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur requested a review from a team August 21, 2023 20:31
@jlaur
Copy link
Contributor Author

jlaur commented Aug 21, 2023

@openhab/add-ons-maintainers - this small fix would be nice to have cherry-picked into 4.0.x in order to get better issue reports.

@jlaur
Copy link
Contributor Author

jlaur commented Aug 23, 2023

@openhab/add-ons-maintainers - one line review, please? I can cherry-pick myself, if you let me. 😉

@wborn
Copy link
Member

wborn commented Aug 24, 2023

Permission granted 😄

@wborn wborn merged commit db651f9 into openhab:main Aug 24, 2023
2 checks passed
@wborn wborn added this to the 4.1 milestone Aug 24, 2023
jlaur added a commit that referenced this pull request Aug 24, 2023
)

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Aug 24, 2023
@jlaur jlaur deleted the 15460-hue-fix-thing-status-description branch August 24, 2023 05:09
@jlaur jlaur changed the title [hue] Fix exception text in bridge status description [hue] Fix exception text in bridge status description (API v2) Dec 22, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…nhab#15475)

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants