[Audio] Fix PCM format and use PipedAudioStream in sources #16111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
audio/fix_container_none
branch
from
21cb831
to
5579d56
Compare
lolodomo
added
enhancement
|
Required PR has been merged last weekend. |
lolodomo
reviewed
Feb 4, 2024
....pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSource.java
Outdated
Show resolved
Hide resolved
|
And a second question: you removed the support of OGG or MP3 audio formats. Is it because they were in fact not really supported ? |
lolodomo
added
rebuild
|
Please note that the build failed. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
The doc says OGG is supported, but as there are no sources available using that format I never tested it, so I though it was better to remove it to avoid confusion. |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…6111) * [Audio] Fix pcm format and use PipedAudioStream * fix rustpotter format changes --------- Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…6111) * [Audio] Fix pcm format and use PipedAudioStream * fix rustpotter format changes --------- Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I want to merge these changes related to the core PR openhab/openhab-core#3960.
It includes changes on the Speech-to-text services to advertise compatibility and handle raw PCM streams (no container header).
Also updates de pulseaudio source to use the new PipedStream class and fixes its format which should use container CONTAINER_NONE (my bad).
NOTE: I have removed the opus support from the googlestt because it's unused.