[amberelectric] Initial contribution

[psmedley]

No description provided.

[psmedley]

I've done my best to include as many relevant fixes from #16667 as possible, as all my bindings run off a similar codebase.

[jlaur]

Thank you for your contribution! I have provided some quick feedback from a first round. In general the code looks good and to the point.

[jlaur]

Thanks for quickly addressing review comments. 👍 I have provided a few new comments. I don't see any major issues in general in the binding, so I'll see if I can complete my review tomorrow.

[psmedley]

4.1.3

[jlaur]

4.1.3

That should be fine since openhab/openhab-core#4016 was backported.

If I set the default currency in OH to AUD, it's fine.

And what is your currency provider settings when you are getting the error?

Did you have a look at #16085 and #16217, I don't know if this would provide any hints?

[psmedley]

4.1.3

That should be fine since openhab/openhab-core#4016 was backported.

If I set the default currency in OH to AUD, it's fine.

And what is your currency provider settings when you are getting the error?

Did you have a look at #16085 and #16217, I don't know if this would provide any hints?

The currency provider setting was not set when I was getting the error.

[jlaur]

Did you have a look at #16085 and #16217, I don't know if this would provide any hints?

The currency provider setting was not set when I was getting the error.

As already posted, have a look here:

openhab-addons/bundles/org.openhab.binding.energidataservice/src/main/java/org/openhab/binding/energidataservice/internal/handler/EnergiDataServiceHandler.java

Lines 500 to 513 in 790d4d0

	private State getEnergyPrice(BigDecimal price, Currency currency) {
	String currencyCode = currency.getCurrencyCode();
	Unit<?> unit = CurrencyUnits.getInstance().getUnit(currencyCode);
	if (unit == null) {
	logger.trace("Currency {} is unknown, falling back to DecimalType", currency.getCurrencyCode());
	return new DecimalType(price);
	}
	try {
	return new QuantityType<>(price + " " + currencyCode + "/kWh");
	} catch (IllegalArgumentException e) {
	logger.debug("Unable to create QuantityType, falling back to DecimalType", e);
	return new DecimalType(price);
	}
	}

The issue is that AUD is not known as a valid unit when no currency provider is set. It's not ideal, but currently has to be handled/worked around.

[psmedley]

Did you have a look at #16085 and #16217, I don't know if this would provide any hints?

The currency provider setting was not set when I was getting the error.

As already posted, have a look here:

openhab-addons/bundles/org.openhab.binding.energidataservice/src/main/java/org/openhab/binding/energidataservice/internal/handler/EnergiDataServiceHandler.java

Lines 500 to 513 in 790d4d0

	private State getEnergyPrice(BigDecimal price, Currency currency) {
	String currencyCode = currency.getCurrencyCode();
	Unit<?> unit = CurrencyUnits.getInstance().getUnit(currencyCode);
	if (unit == null) {
	logger.trace("Currency {} is unknown, falling back to DecimalType", currency.getCurrencyCode());
	return new DecimalType(price);
	}
	try {
	return new QuantityType<>(price + " " + currencyCode + "/kWh");
	} catch (IllegalArgumentException e) {
	logger.debug("Unable to create QuantityType, falling back to DecimalType", e);
	return new DecimalType(price);
	}
	}

The issue is that AUD is not known as a valid unit when no currency provider is set. It's not ideal, but currently has to be handled/worked around.

Should be fixed in latest commit :)

[jlaur]

LGTM, thanks!

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

[jlaur]

@psmedley - sorry, two small things before merging:

• Can you please add yourself as binding maintainer?
• There is one checkstyle warning to fix. You could take a look at target/code-analysis/report.html.

[psmedley]

Just wanted to say thanks for @jlaur for his prompt reviews and patience with me in getting this to the point of being merged!

[psmedley]

LGTM, thanks!

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

https://github.com/psmedley/openhab-docs/tree/amberelectric is ready to create the PR once merge occurs.