[modbus] Export thing handler interface for upcoming bundles #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exporting the thing handler interface and the required other interfaces makes it possible to textend this binding by other bundles. Such an use case is when custom handlers are written to specific devices. Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
mrbig
force-pushed
the
4053-modbus-public-handlers
branch
from
dfa3d25
to
67c70a4
Compare
cweitkamp
reviewed
Oct 5, 2018
| * @author Nagy Attila Gabor - Split the original ModbusBindingConstants in two | ||
| */ | ||
| @NonNullByDefault | ||
| public class ModbusBindingConstants { |
There was a problem hiding this comment.
Should we give this class (or the original ModbusBindingConstants class) a different name to make it clear for everyone that one of them is internal and the other one is public API? Wdyt?
There was a problem hiding this comment.
Totally agree, I just could not come up with a good name. As I can see this separation is fairly new, I would like to ask you guys to propose a naming convention here.
There was a problem hiding this comment.
Off-the-cuff: ModbusBindingConstants and ModbusBindingConstantsInternal. 😉
…ternal Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
mrbig
force-pushed
the
4053-modbus-public-handlers
branch
from
a7fca49
to
91a43f7
Compare
|
Thank you! |
chaton78
pushed a commit
to chaton78/openhab-addons
that referenced
this pull request
Jan 1, 2019
…#4077) * [modbus] Export thing handler interface for upcoming bundles Exporting the thing handler interface and the required other interfaces makes it possible to textend this binding by other bundles. Such an use case is when custom handlers are written to specific devices. * [modbus] Renamed internal constants class to ModbusBindingConstantsInternal Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: Pascal Larin <plarin@gmail.com>
magx2
pushed a commit
to magx2/openhab2-addons
that referenced
this pull request
Mar 18, 2019
…#4077) * [modbus] Export thing handler interface for upcoming bundles Exporting the thing handler interface and the required other interfaces makes it possible to textend this binding by other bundles. Such an use case is when custom handlers are written to specific devices. * [modbus] Renamed internal constants class to ModbusBindingConstantsInternal Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
arjanmels
pushed a commit
to arjanmels/openhab2-addons
that referenced
this pull request
Mar 24, 2019
…#4077) * [modbus] Export thing handler interface for upcoming bundles Exporting the thing handler interface and the required other interfaces makes it possible to textend this binding by other bundles. Such an use case is when custom handlers are written to specific devices. * [modbus] Renamed internal constants class to ModbusBindingConstantsInternal Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: Arjan Mels <arjan.mels@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #4053
The modbus binding could easily be extended by other bundles to add device specific things and their handlers. There is already such a work in progress, see issue #3216
Fortunately @ssalonen did a nice work separating interfaces from actual implementations so exporting the base handler interfaces is quite straightforward.
This work is based on the zigbee and bluetooth package practices and work by @triller-telekom
I've split the ModbusBindingConstants class also in two: one that is public and could be used by other bundles and one that remains internal.