Simplify assertions #3996
Merged
Simplify assertions #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the appropriate assertion methods results in less and easier to read code as well as better error messages when assertions fail. Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
requested changes
Jan 3, 2024
| @@ -76,6 +76,6 @@ public void testTokenNotExpiredEvenWithBuffer() { | |||
| // token has a life time of 60 seconds | |||
| token.setExpiresIn(60); | |||
|
|
|||
| assertTrue(!token.isExpired(Instant.now(), 10), "Token should have been expired due to buffer"); | |||
| assertFalse(token.isExpired(Instant.now(), 10), "Token should have been expired due to buffer"); | |||
There was a problem hiding this comment.
Isn't the test and the message a contradiction? We test isExpired == false and the failure message says the token should have expired?
There was a problem hiding this comment.
Fixed the text. I think it was copied from testTokenExpiredDueToBuffer to testTokenNotExpiredEvenWithBuffer
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
approved these changes
Jan 3, 2024
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
* Simplify assertions Using the appropriate assertion methods results in less and easier to read code as well as better error messages when assertions fail. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the appropriate assertion methods results in less and easier to read code as well as better error messages when assertions fail.