Fix CurrencyUnit #4016
Merged
Fix CurrencyUnit #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@J-N-K, @openhab/core-maintainers - perhaps something to be considered for 4.1.1 since it fixes an issue in a new 4.1 feature? |
|
@J-N-K Should this be backported to 4.1.x? |
|
Yes, especially because of the symbol/code issue. The conversion bug will probably not be an issue on 4.1 because there is no currency provider with more than one currency. |
|
Ok, cherry-picked to |
kaikreuzer
added
the
patch
cipianpascu
pushed a commit
to cipianpascu/openhab-core
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues that were recently detected regarding the new currency units:
Currency codes could not be used for the base currency (but for additional currencies) when a symbol is defined. The reason is that in this case only the symbol and not symbol and label were added to the unit formatter.
Units composed of a currency and an additional currency (like
EUR/kWh) were not properly converted (only the non-currency part was converted). This was caused by two problems:CurrencyUnitdid not inherit fromAbstractUnitand therefore the converter was not properly found (alwaysIDENTITY). After I fixed that, an additional problem occurred: theCurrencyConvertercould not be used because the list of converters is a final, non-accessible list.@jlaur FYI.