-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ThingHandlerService documentation #2194
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, Jan.
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
Maybe you can also update the other 2 lines using |
Signed-off-by: Jan N. Klug <github@klug.nrw>
Can someone give me a sign when we are done with the review? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's done after these minor comments have been addressed:
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw>
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 me 2, thanks
* New ThingHandlerService documentation * Update developers/bindings/index.md Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw> * improvement * improvement Signed-off-by: Jan N. Klug <github@klug.nrw> * Update developers/bindings/index.md Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw> * Update developers/bindings/index.md Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw> * Update developers/bindings/index.md Co-authored-by: Wouter Born <github@maindrain.net> Signed-off-by: J-N-K <github@klug.nrw> --------- Signed-off-by: J-N-K <github@klug.nrw> Signed-off-by: Jan N. Klug <github@klug.nrw> Co-authored-by: Wouter Born <github@maindrain.net>
Related to openhab/openhab-core#3957