Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ThingHandlerService documentation #2194

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 31, 2023

Copy link

netlify bot commented Dec 31, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit ea671db
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/659563f78bcaed0008c08cff
😎 Deploy Preview https://deploy-preview-2194--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, Jan.

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone Dec 31, 2023
@stefan-hoehn stefan-hoehn added the stat: dependency 💥 This issue/pr has a dependency in another repo label Dec 31, 2023
developers/bindings/index.md Outdated Show resolved Hide resolved
J-N-K and others added 2 commits January 2, 2024 12:39
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>
@wborn
Copy link
Member

wborn commented Jan 2, 2024

Maybe you can also update the other 2 lines using Collections.singleton ? 🙂

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K marked this pull request as ready for review January 2, 2024 11:53
@stefan-hoehn
Copy link
Contributor

Can someone give me a sign when we are done with the review? :)

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's done after these minor comments have been addressed:

developers/bindings/index.md Outdated Show resolved Hide resolved
developers/bindings/index.md Outdated Show resolved Hide resolved
developers/bindings/index.md Outdated Show resolved Hide resolved
J-N-K and others added 3 commits January 3, 2024 14:40
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>
Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Jan 3, 2024

done

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too now!

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 me 2, thanks

@stefan-hoehn stefan-hoehn removed the stat: dependency 💥 This issue/pr has a dependency in another repo label Jan 3, 2024
@stefan-hoehn stefan-hoehn merged commit e4996fb into openhab:main Jan 3, 2024
5 checks passed
@J-N-K J-N-K deleted the discovery branch January 3, 2024 14:51
pgfeller pushed a commit to pgfeller/openhab-docs that referenced this pull request Jan 15, 2024
* New ThingHandlerService documentation

* Update developers/bindings/index.md

Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>

* improvement

* improvement

Signed-off-by: Jan N. Klug <github@klug.nrw>

* Update developers/bindings/index.md

Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>

* Update developers/bindings/index.md

Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>

* Update developers/bindings/index.md

Co-authored-by: Wouter Born <github@maindrain.net>
Signed-off-by: J-N-K <github@klug.nrw>

---------

Signed-off-by: J-N-K <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Co-authored-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants