Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeathomesystem] Apply logo for free@home binding #2286

Merged
merged 14 commits into from
May 19, 2024

Conversation

andrasU
Copy link
Contributor

@andrasU andrasU commented Apr 21, 2024

Apply logo for free@home binding

Apply logo for free@home binding

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Copy link

netlify bot commented Apr 21, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 62f004e
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/664a6b73fb33b0000898ad5a
😎 Deploy Preview https://deploy-preview-2286--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrasU andrasU changed the title Apply logo for free@home binding [freeathomesystem] Apply logo for free@home binding Apr 21, 2024
@florian-h05
Copy link
Contributor

Hi @andrasU,

can you please provide the logo as SVG?
See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui.

@jlaur linked the stable docs deployed when openHAB 4.1.0 was released, I’ve added SVG support for add-on logos after the release so these docs there are outdated, the current ones are linked above.

stefan-hoehn and others added 5 commits April 28, 2024 07:38
…openhab#2290)

* [saicismart] Add addon logo for MG Cars from https://de.wikipedia.org/wiki/Datei:Mg_logo.svg

Signed-off-by: dougculnane <doug@culnane.net>

* [saicismart] Use SVG not PNG for addon logo

Signed-off-by: dougculnane <doug@culnane.net>

* [renault] Use SVG not PNG for addon logo

Signed-off-by: dougculnane <doug@culnane.net>

---------

Signed-off-by: dougculnane <doug@culnane.net>
* update persistence actions docs

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* correction

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* document HistoricItem

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* review adjustment

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

---------

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
The link for the update-description-1.0.0.xsd is wrong.

Signed-off-by: M Valla <12682715+mvalla@users.noreply.github.com>
@andrasU
Copy link
Contributor Author

andrasU commented May 5, 2024

Hi @andrasU,

can you please provide the logo as SVG? See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui.

@jlaur linked the stable docs deployed when openHAB 4.1.0 was released, I’ve added SVG support for add-on logos after the release so these docs there are outdated, the current ones are linked above.

@florian-h05
In the meantime I have the SVG version of the logo. I will push the change to this PR

Replace logo of free@home binding with SVG version

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
@jlaur
Copy link
Contributor

jlaur commented May 5, 2024

Please wait a bit merging this PR. The binding is currently in the process of being renamed from freeathomesystem to freeathome: openhab/openhab-addons#16718.

@jlaur
Copy link
Contributor

jlaur commented May 5, 2024

@andrasU - can you rename the file to "freeathome.svg" now that the binding will be renamed?

@jlaur
Copy link
Contributor

jlaur commented May 9, 2024

The binding has been renamed.

lolodomo and others added 3 commits May 12, 2024 11:42
* [airgradient] Add logo for recently added binding

* Add airgradient logo in SVG format

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>

---------

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrasU Can you try rebasing this because the other PRs run through.

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone May 19, 2024
GiviMAD and others added 4 commits May 19, 2024 23:10
* [multimedia] Add record and transcribe commands

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>

* apply pr review

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>

* fix md errors

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>

---------

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Co-authored-by: stefan-hoehn <mail@stefanhoehn.com>
Apply logo for free@home binding

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Replace logo of free@home binding with SVG version

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
@stefan-hoehn stefan-hoehn merged commit 0e55faf into openhab:main May 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.