Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to update repo sources in openhab-cli #144

Closed
wants to merge 1 commit into from
Closed

Add command to update repo sources in openhab-cli #144

wants to merge 1 commit into from

Conversation

BClark09
Copy link
Member

Closes #136

  • Adds template rpm and apt source files as well so that users can easily switch repos.
  • Adds the repos current public key so that it can be easily updated in the future.

Signed-off-by: Ben Clark ben@benjyc.uk

@BClark09
Add command to update repo sources in openhab-cli
c425dd8 
- Adds template rpm and apt source files as well so that users can easily switch repos.
- Adds the repos current public key so that it can be easily updated in the future.

Signed-off-by: Ben Clark <ben@benjyc.uk>
@BClark09
Copy link
Member Author

Thoughts on this addition would be most welcome.

@openhab/openhabian-maintainers, just an FYI - this may be useful to call when calling openHABians update functions.

@kaikreuzer, I've added this function in preparation for two events:

  1. We change the suggested testing repo to Artifactory, we can update Bintray with a final package that has an updated source template, and then users need only use the command openhab-cli update-repo testing (or we can do this for them).

  2. The public key expires on 2019-07-25, ahead of this time we should probably update the public key. I have included a copy of it in this repo so that we can replace it if needed.

@kaikreuzer
Copy link
Member

Just noticed that this is more than 1 year old by now...
@BClark09 Are you still waiting for having it merged by a @openhab/linuxpkg-maintainers? As there are just 2, I guess you can decide to allow self-merging of PRs (at least after a few days), wdyt?

@theoweiss
Copy link
Member

I'm in maintenance mode ;-) . @BClark09 is the master and should not wait for my lgtm.

@BClark09
Copy link
Member Author

As there are just 2, I guess you can decide to allow self-merging of PRs (at least after a few days), wdyt?

Sounds fair, but I think it would also make sense to request that for any PR that may affect openHABian that there should be a review from another person in @openhab/openhabian-maintainers. I'll request a review for next time.

As for the PR I think there's probably a better approach to this than what I submitted all that time ago so I'll close this for now in favour of submitting a different one.

@BClark09 BClark09 closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
.deb enhancement openhab-cli .rpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install repo paths on install or update
3 participants
@BClark09 @kaikreuzer @theoweiss