From e4a07e41b5c9bb25b4b526659b4e04f1c30f1ab5 Mon Sep 17 00:00:00 2001
From: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
Date: Fri, 20 Oct 2023 15:31:08 +0200
Subject: [PATCH] Configurable visibility of semantic model cards

Only render model-card if `visible` computed property is `true`.
Hide divs in model-tabs which do not have a visible model-card.
Closes #2143

Signed-off-by: Thomas Wunschel <thomas.wunschel@twistsolutions.de>
Signed-off-by: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
---
 .../org.openhab.ui/web/src/components/cards/model-card.vue    | 2 +-
 bundles/org.openhab.ui/web/src/pages/home/model-tab.vue       | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/bundles/org.openhab.ui/web/src/components/cards/model-card.vue b/bundles/org.openhab.ui/web/src/components/cards/model-card.vue
index b588cdb29d..3f063b66f6 100644
--- a/bundles/org.openhab.ui/web/src/components/cards/model-card.vue
+++ b/bundles/org.openhab.ui/web/src/components/cards/model-card.vue
@@ -1,5 +1,5 @@
 <template>
-  <f7-card expandable ref="card" class="model-card" :class="type + '-card'" :animate="$f7.data.themeOptions.expandableCardAnimation !== 'disabled'" card-tablet-fullscreen @card:opened="cardOpening" @card:closed="cardClosed">
+  <f7-card v-if="visible" expandable ref="card" class="model-card" :class="type + '-card'" :animate="$f7.data.themeOptions.expandableCardAnimation !== 'disabled'" card-tablet-fullscreen @card:opened="cardOpening" @card:closed="cardClosed">
     <f7-card-content :padding="false">
       <div :class="(!backgroundImageUrl) ? `bg-color-${color}` : undefined" :style="{ height: `calc(var(--f7-safe-area-top) + ${headerHeight})` }">
         <f7-card-header :text-color="config.invertText ? 'black' : 'white'" class="display-block card-header" :style="{ height: `calc(var(--f7-safe-area-top) + ${headerHeight})` }">
diff --git a/bundles/org.openhab.ui/web/src/pages/home/model-tab.vue b/bundles/org.openhab.ui/web/src/pages/home/model-tab.vue
index 38bf765e52..54641e588e 100644
--- a/bundles/org.openhab.ui/web/src/pages/home/model-tab.vue
+++ b/bundles/org.openhab.ui/web/src/pages/home/model-tab.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="disable-user-select">
+  <div class="disable-user-select model-tab">
     <div v-for="(elements, idx) in groups" :key="idx">
       <f7-block-title medium v-if="elements.length > 0 && elements[0].separator">
         {{ elements[0].separator }}
@@ -19,6 +19,8 @@
 </template>
 
 <style lang="stylus">
+.model-tab > div:not(:has(.model-card))
+  display none
 
 .model-cards-section
   justify-content center