Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-139: add core tasks fe #33

Merged
merged 3 commits into from
Jul 6, 2023
Merged

CM-139: add core tasks fe #33

merged 3 commits into from
Jul 6, 2023

Conversation

jdolkowski
Copy link
Collaborator

@jdolkowski jdolkowski commented Jul 5, 2023 •
edited
Loading

@jdolkowski jdolkowski marked this pull request as draft July 5, 2023 00:30
@jdolkowski jdolkowski mentioned this pull request Jul 5, 2023
Merged
@jdolkowski jdolkowski marked this pull request as ready for review July 5, 2023 09:02
sniedzielski
sniedzielski reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this stage please refer to two my comments. Generally looks ok to me. I haven't found nothing critical for me. Please fix those commented lines of code.
Please also remember to add some information to README based on the template

src/components/BenefitPlanTaskPreviewTable.js Outdated Show resolved Hide resolved
src/components/BenefitPlanTasksSearcher.js Outdated Show resolved Hide resolved
olewandowski1
olewandowski1 reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@olewandowski1 olewandowski1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdolkowski Overall LGTM. Nevertheless, I see that we're completely inconsistent with a way of implementing styles and translations. We could talk it through and align if needed.

Note: Ofc, take a look on @sniedzielski 's comments.

@sniedzielski sniedzielski self-requested a review July 6, 2023 13:54
@sniedzielski sniedzielski merged commit e52d1c7 into develop Jul 6, 2023
@sniedzielski sniedzielski deleted the feature/CM-139 branch July 6, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olewandowski1 olewandowski1 olewandowski1 left review comments

@sniedzielski sniedzielski sniedzielski approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdolkowski @sniedzielski @olewandowski1