8254311: Incorrect statements in createWindowsDevkit2017.sh

[luhenry]

We made a typo in #212 when updating make/devkit/createWindowsDevkit2017.sh.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254311: Incorrect statements in createWindowsDevkit2017.sh

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/581/head:pull/581
$ git checkout pull/581

[bridgekeeper]

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[luhenry]

/issue add 8254311

[openjdk]

⚠️ @luhenry a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master aaa0a2a04792d7c84150e9d972790978ffcc6890
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@luhenry This issue is referenced in the PR title - it will now be updated.

[openjdk]

@luhenry The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (790078a)

[openjdk]

@luhenry This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254311: Incorrect statements in createWindowsDevkit2017.sh

Reviewed-by: erikj, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
• 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
• 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
• 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store
• 65393a0: 8229867: Re-examine synchronization usages in http and https protocol handlers
• 6fe209b: 8254671: ZGC: Remove unused roots iterator types
• 9c93490: 8254177: (tz) Upgrade time-zone data to tzdata2020b
• 5d6a625: 8254576: ZGC: Clean up timers in roots iterators
• 508c8a9: 8247591: Document Alpine Linux build steps in OpenJDK build guide
• 63009f9: 8247589: Implementation of Alpine Linux/x64 Port
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/aaa0a2a04792d7c84150e9d972790978ffcc6890...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[luhenry]

@TobiHartmann as you reported https://bugs.openjdk.java.net/browse/JDK-8254311, could you please review and eventually sponsor? Thank you!

[TobiHartmann]

Looks good to me.

[luhenry]

/integrate

[openjdk]

@luhenry
Your change (at version 790078a) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

@TobiHartmann @luhenry Since your change was applied there have been 51 commits pushed to the master branch:

• ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
• 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
• 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
• 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store
• 65393a0: 8229867: Re-examine synchronization usages in http and https protocol handlers
• 6fe209b: 8254671: ZGC: Remove unused roots iterator types
• 9c93490: 8254177: (tz) Upgrade time-zone data to tzdata2020b
• 5d6a625: 8254576: ZGC: Clean up timers in roots iterators
• 508c8a9: 8247591: Document Alpine Linux build steps in OpenJDK build guide
• 63009f9: 8247589: Implementation of Alpine Linux/x64 Port
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/aaa0a2a04792d7c84150e9d972790978ffcc6890...master

Your commit was automatically rebased without conflicts.

Pushed as commit 715e24a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.