Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336451: [11u] GHA macos-13 builder is unable to resolve local hostname #2861

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jul 16, 2024

This fixes JDK-8336451.

This is a problem with the latest Github macos runners (see actions/runner-images#8649) that makes it impossible for getaddrinfo to properly resolve the builder's hostname. The issue has been opened since late 2023.

Not being able to resolve the local hostname makes jdk/tier1 and langtools/tier1 to fail on this platform, as the socket transport cannot establish a connection.

There are still some other sprintfs in the codebase, but these do not affect the macos builds, and can be possibly backported later on, once the macos builds are again in place.

The macos builds and tests are expected to succeed after this fix is in place.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336451 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2854 must be integrated first

Issue

  • JDK-8336451: [11u] GHA macos-13 builder is unable to resolve local hostname (Enhancement - P4) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2861/head:pull/2861
$ git checkout pull/2861

Update a local copy of the PR:
$ git checkout pull/2861
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2861

View PR using the GUI difftool:
$ git pr show -t 2861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2861.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/2854 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2024

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not an expert in this area.

@vieiro
Copy link
Contributor Author

vieiro commented Aug 26, 2024

Hi @TheRealMDoerr . Thanks for the review.

Github has now deployed new images that solve the problem, so this PR is no longer required, closing the PR then.

Here's a test to verify the images work properly with getaddrinfo.

@vieiro vieiro closed this Aug 26, 2024
@vieiro vieiro deleted the backports/JDK-8336451 branch September 5, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants