8367415: Fully encapsulate array allocation in oopFactory

[coleenp]

This makes oopFactory and deoptimization the only friends of private ArrayKlass::allocate_instance. This is similar to the PR openjdk/jdk#27372 in mainline with some extra handling for new_refArray (rather than calling RefArrayKlass::allocate_instance() directly.
Tested with tier1-4.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8367415: Fully encapsulate array allocation in oopFactory (Bug - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1602/head:pull/1602
$ git checkout pull/1602

Update a local copy of the PR:
$ git checkout pull/1602
$ git pull https://git.openjdk.org/valhalla.git pull/1602/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1602

View PR using the GUI difftool:
$ git pr show -t 1602

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1602.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367415: Fully encapsulate array allocation in oopFactory

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the lworld branch:

• 01225ee: 8367518: TestRedundantLea.java fails in Valhalla
• 0ef9bd4: 8368022: serviceability/dcmd/gc/HeapDumpParallelTest.java fails missing output
• feee12a: 8368002: [lworld] Crash in ThawBase::remove_top_compiled_frame_from_chunk
• ... and 93 more: https://git.openjdk.org/valhalla/compare/2c2f4b2b98be4e9be4bae1aa0db94ccc08b743e0...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full (eb6f1d16)
• 01: Full - Incremental (990cf11f)
• 00: Full (5712324e)

[fparain]

Is this needed? There's already one at line 60.

[coleenp]

It's not. I moved the methods to be where they are in mainline. Thanks for noticing this.

[openjdk]

@coleenp this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout oopFactory
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

[coleenp]

Thanks Fred.
/integrate

[openjdk]

Going to push as commit 77d067c.
Since your change was applied there have been 96 commits pushed to the lworld branch:

• 01225ee: 8367518: TestRedundantLea.java fails in Valhalla
• 0ef9bd4: 8368022: serviceability/dcmd/gc/HeapDumpParallelTest.java fails missing output
• feee12a: 8368002: [lworld] Crash in ThawBase::remove_top_compiled_frame_from_chunk
• ... and 93 more: https://git.openjdk.org/valhalla/compare/2c2f4b2b98be4e9be4bae1aa0db94ccc08b743e0...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 77d067c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.