Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to run an application on either CLASSPATH or MODULEPATH #92

Merged
merged 26 commits into from
Oct 16, 2020
Merged

Add option to run an application on either CLASSPATH or MODULEPATH #92

merged 26 commits into from
Oct 16, 2020

Commits on Jun 24, 2020

  1. Working directory should be resolved before querying for executable path

    @abhinayagarwal
    abhinayagarwal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e3e9a2c View commit details
    Browse the repository at this point in the history

  2. Add dependencies to module-path only when the project is modular

    @abhinayagarwal
    abhinayagarwal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    6b352e8 View commit details
    Browse the repository at this point in the history

  3. Add runtimePath parameter

    @abhinayagarwal
    abhinayagarwal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    9652045 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/openjfx/javafx-maven-plugin… 

    … into issue-91
    @abhinayagarwal
    abhinayagarwal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    71c0eb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Add jlinkOptions parameter to pass options to jlink executable

    @abhinayagarwal
    abhinayagarwal committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    594cc51 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Remove DEFAULT from RuntimePath

    @abhinayagarwal
    abhinayagarwal committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    0bbf8fb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Remove defaultValue for runtimePath

    @abhinayagarwal
    abhinayagarwal committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d4f2fb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Changes as per review

    @abhinayagarwal
    abhinayagarwal committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    af073ed View commit details
    Browse the repository at this point in the history

  2. Refactor JavaFXRunMojo

    @abhinayagarwal
    abhinayagarwal committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    54e5682 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary leading space in entries

    @abhinayagarwal
    abhinayagarwal committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    22b7c01 View commit details
    Browse the repository at this point in the history

  4. Ignore module-info.java file if runtimePathOption is set as CLASSPATH

    @abhinayagarwal
    abhinayagarwal committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    b3c891f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/openjfx/javafx-maven-plugin… 

    … into issue-91
    @abhinayagarwal
    abhinayagarwal committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    fb34a43 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Update README.md

    @abhinayagarwal
    abhinayagarwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    87970cc View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Add check for Application class

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    217c0c0 View commit details
    Browse the repository at this point in the history

  2. Add tests for CLASSPATH runtimePathOption

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    9c67ae0 View commit details
    Browse the repository at this point in the history

  3. Update JavaFX version in test pom

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    8f915b1 View commit details
    Browse the repository at this point in the history

  4. Revert changes made for jlinkOptions

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    351a7c6 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    aafdb53 View commit details
    Browse the repository at this point in the history

  6. Revert test changes made for jlinkOptions

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    9db5fa9 View commit details
    Browse the repository at this point in the history

  7. More reverts

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    ff163ca View commit details
    Browse the repository at this point in the history

  8. Ignore module-name from mainClass if runtimePathOption is CLASSPATH

    @abhinayagarwal
    abhinayagarwal committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    319d878 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Changes as per review

    @abhinayagarwal
    abhinayagarwal committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ebcdee1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Update README.md

    @abhinayagarwal
    abhinayagarwal committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    e9835f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Update README.md

    @abhinayagarwal
    abhinayagarwal committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    8ba1c15 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Remove unnecessary checks while moving dependencies when runtimePathO… 

    …ption is MODULEPATH
    @abhinayagarwal
    abhinayagarwal committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    130a2bd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Changes as per feedback

    @abhinayagarwal
    abhinayagarwal committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    182586b View commit details
    Browse the repository at this point in the history