Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD) #2822

Closed
whedon opened this issue Nov 6, 2020 · 26 comments

Comments

@whedon
Copy link

whedon commented Nov 6, 2020

Submitting author: @mengaldo (Gianmarco Mengaldo)
Repository: https://github.com/mengaldo/PySPOD
Version: v0.3
Editor: @eloisabentivegna
Reviewers: @albertonogueira, @Joao-L-S-Almeida, @jdmoorman
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @mengaldo. Currently, there isn't an JOSS editor assigned to your paper.

@mengaldo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 6, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 6, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.89 s (80.0 files/s, 39100.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      14           2289           2323           8445
HTML                            12           1734             44           4575
Python                          24            814           1301           3353
SVG                              1              0              0           2671
CSS                              5            183             43            722
Jupyter Notebook                 7              0           4829            564
Markdown                         2             82              0            255
reStructuredText                 2             94             68            176
YAML                             2             11             10             55
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            71           5219           8626          20851
-------------------------------------------------------------------------------


Statistical information for the repository '0a6b9a2db80e74d4f97642a7' was
gathered on 2020/11/06.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Gianmarco Mengaldo              69         26810           7800           98.58
mengaldo                         1             7            492            1.42

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Gianmarco Mengaldo        18525           69.1          0.1               16.97

@whedon
Copy link
Author

whedon commented Nov 6, 2020

PDF failed to compile for issue #2822 with the following error:

Can't find any papers to compile :-(

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf from branch papers/JOSS

@whedon
Copy link
Author

whedon commented Nov 6, 2020

Attempting PDF compilation from custom branch papers/JOSS. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 6, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@harpolea @eloisabentivegna @VivianePons could one of you handle this submission? Thanks!

@eloisabentivegna
Copy link

I can!

@eloisabentivegna
Copy link

@whedon assign @eloisabentivegna as editor

@whedon
Copy link
Author

whedon commented Nov 7, 2020

OK, the editor is @eloisabentivegna

@eloisabentivegna
Copy link

@jdmoorman, would you be available to review this submission?

@mengaldo
Copy link

Dear Eloisa, I have no particular suggestions for reviewers. Please, let me know if you need any additional information to proceed with the review. Best, Gianmarco

@eloisabentivegna
Copy link

Dear Eloisa, I have no particular suggestions for reviewers. Please, let me know if you need any additional information to proceed with the review. Best, Gianmarco

Thanks, @mengaldo! One reviewer has agreed to work on this submission, but we will need at least another one. Please bear with me for a little longer. Thanks!

@eloisabentivegna
Copy link

@whedon add @albertonogueira as reviewer

@whedon
Copy link
Author

whedon commented Nov 24, 2020

OK, @albertonogueira is now a reviewer

@eloisabentivegna
Copy link

@whedon add @Joao-L-S-Almeida as reviewer

@whedon
Copy link
Author

whedon commented Nov 24, 2020

OK, @Joao-L-S-Almeida is now a reviewer

@mengaldo
Copy link

@eloisabentivegna Thank you!

@jdmoorman
Copy link

@jdmoorman, would you be available to review this submission?

I am available if you need another reviewer

@eloisabentivegna
Copy link

I am available if you need another reviewer

Thanks, @jdmoorman! I will add you as well.

@eloisabentivegna
Copy link

@whedon add @jdmoorman as reviewer

@whedon
Copy link
Author

whedon commented Nov 25, 2020

OK, @jdmoorman is now a reviewer

@eloisabentivegna
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 25, 2020

OK, I've started the review over in #2862.

@whedon whedon closed this as completed Nov 25, 2020
@albertonogueira
Copy link

@Joao-L-S-Almeida and @albertonogueira are testing PySPOD in NASA's GMAO dataset to check the library capabilities. We started filling in the checklist review.

@eloisabentivegna
Copy link

eloisabentivegna commented Dec 5, 2020

@albertonogueira, @Joao-L-S-Almeida, the review will now continue in issue #2862. Could you leave your comments there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants